Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/upgrade: Handle container case #3659

Merged
merged 4 commits into from
Nov 20, 2023

Conversation

cgwalters
Copy link
Member

upgrade: Remove old tar code

We can rely on the OS being a container now.


Port to use rpmostree-client-go

This is a general cleanup, but a specific motivation here
is we were missing the container-image-reference field which I
want to use later.


Rename GetRpmOstreeStatusJSON -> GetRpmOstreeStatus

Because the fact that it was JSON is irrelevant to the caller.


tests/upgrade: Handle container case

We switched rawhide to default to a container image reference;
adapt the code to handle this case. We skip all the zincati
stuff here and just directly rebase.

Closes: coreos/fedora-coreos-tracker#1614


We can rely on the OS being a container now.
This is a general cleanup, but a specific motivation here
is we were missing the container-image-reference field which I
want to use later.
Because the fact that it was JSON is irrelevant to the caller.
dustymabe
dustymabe previously approved these changes Nov 20, 2023
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. It shouldn't affect that path, but maybe let's hold this until Tuesday to let our triple release builds go through smooth.

mantle/kola/tests/upgrade/basic.go Outdated Show resolved Hide resolved
mantle/kola/tests/upgrade/basic.go Outdated Show resolved Hide resolved
We switched rawhide to default to a container image reference;
adapt the code to handle this case.  We skip all the zincati
stuff here and just directly rebase.

Closes: coreos/fedora-coreos-tracker#1614
@cgwalters
Copy link
Member Author

{err=error: failed to read input object (not a Template?): resource mapping not found for name: "clean-up" namespace: "" from "/var/lib/jenkins/jobs/coreos-assembler/branches/PR-3659/workspace/process17175549336496222947.markup": no matches for kind "Template" in version "v1"
ensure CRDs are installed first

No idea what's going on there, something in Jenkins just fell over looks like.

@dustymabe dustymabe enabled auto-merge (rebase) November 20, 2023 22:27
@dustymabe dustymabe merged commit 57af592 into coreos:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rawhide]: basic/upgrade-from-previous failing in recent Rawhide builds
2 participants