deps: drop awscli, install awscli2 on x86_64 only
#3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not super confident this won't break something but there is only one way to find out! |
|
rebase this to pick up #3654 and hopefully it will then pass CI |
The package is noarch, but one of its dep isn't available on s390x.[[1]] What's new in Fedora 39 is the AwsCli[[2]] change in which the `awscli` was retired in favour of `awscli2`. In fact, it turns out even on f38 we were pulling in `awscli2` on all arches except s390x, where we still pulled `awscli`. Anyway, cosa itself doesn't use the `aws` CLI but the Python/Go API libraries directly, which *are* available on all arches. The pipeline does use it in one spot[[3]], but that's only ever run from the Jenkins controller, which is x86_64. So let's just move the dep to be x86_64-specific and make it clear it's not for cosa itself but for the pipeline and developer convenience. [1]: https://src.fedoraproject.org/rpms/awscli2/blob/62f260a00a87/f/awscli2.spec#_41 [2]: https://fedoraproject.org/wiki/Changes/AwsCli [3]: https://github.com/coreos/fedora-coreos-pipeline/blob/b2dc3c8a1c02e3838b933e09ed6bfc8d8dfe9153/utils.groovy#L214
jlebon
force-pushed
the
pr/awscli-s390x
branch
from
de21094 to
5377a40
Compare
I did scan both cosa and the pipeline so I'm somewhat confident, but it's definitely possible I missed something. I could imagine something outside of those two that uses the cosa image and does AWS stuff, but on s390x... seems unlikely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package is noarch, but one of its dep isn't available on s390x.[1]
What's new in Fedora 39 is the AwsCli[2] change in which the
awscliwas retired in favour of
awscli2.In fact, it turns out even on f38 we were pulling in
awscli2on allarches except s390x, where we still pulled
awscli.Anyway, cosa itself doesn't use the
awsCLI but the Python/Go APIlibraries directly, which are available on all arches.
The pipeline does use it in one spot[3], but that's only ever run from
the Jenkins controller, which is x86_64.
So let's just move the dep to be x86_64-specific and make it clear it's
not for cosa itself but for the pipeline and developer convenience.