Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nix): Add missing quotes for dev_version if custom value #130

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Sep 2, 2024

Hi, I believe I spotted a bug:

with the meta.yml snippet

tested_coq_nix_versions:
  - coq_version: 'v8.19'
    extra_dev_dependencies:
      - nix_name: mathcomp
        dev_version: 'mathcomp-2.2.0'

I was getting

      matrix:
        overrides:
          - 'coq = "v8.19"; mathcomp = mathcomp-2.2.0'

instead of

      matrix:
        overrides:
          - 'coq = "v8.19"; mathcomp = "mathcomp-2.2.0"'

Cc @Zimmi48 Does my patch look good to you?

@erikmd erikmd requested a review from Zimmi48 September 2, 2024 17:21
@Zimmi48 Zimmi48 merged commit e34c0cb into master Oct 21, 2024
2 checks passed
@Zimmi48 Zimmi48 deleted the fix-nix-version branch October 21, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants