Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid relying on Add Field calling Add Ring. #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maximedenes
Copy link
Contributor

This is in preparation for coq/coq#10734

Should be backward compatible

This is in preparation for coq/coq#10734

Should be backward compatible
@spitters
Copy link
Collaborator

Ignored instance declaration for “in_mon_unit_zero”: “

∀ (K V : Type) (Ke : Equiv K) (Kplus : Plus K) (Kmult : Mult K)

(Kzero : Zero K) (Kone : One K) (Knegate : Negate K)

(Krecip : DecRecip K) (Ve : Equiv V) (Vop : SgOp V)

(Vunit : MonUnit V) (Vnegate : Negate V) (sm : ScalarMult K V)

(inp : Inproduct K V) (Kle : Le K),

InnerProductSpace K V → ∀ v : V, 0 = ⟨ v, v ⟩ ↔ v = mon_unit” is not a class

[not-a-class,typeclasses]

COQC theory/fields.v

File "./theory/fields.v", line 1, characters 0-112:

Warning: Notation "_ = _" was already used in scope type_scope.

[notation-overridden,parsing]

File "./theory/fields.v", line 1, characters 0-112:

Warning: Notation "_ ≠ _" was already used in scope type_scope.

[notation-overridden,parsing]

COQC theory/dec_fields.v

File "./theory/dec_fields.v", line 1, characters 0-199:

Warning: Notation "_ = _" was already used in scope type_scope.

[notation-overridden,parsing]

File "./theory/dec_fields.v", line 1, characters 0-199:

Warning: Notation "_ ≠ _" was already used in scope type_scope.

[notation-overridden,parsing]

File "./theory/dec_fields.v", line 209, characters 2-25:

Error: F2_ring_lemma1 already exists.

@maximedenes
Copy link
Contributor Author

Ok, so this patch is in fact not backward compatible. I'll prepare an overlay in the Coq PR.

@Zimmi48
Copy link
Member

Zimmi48 commented Jan 31, 2020

I'll prepare an overlay in the Coq PR.

But there should be a backward compatible patch. Otherwise, it's not going to be possible to merge the PR, even after the Coq PR is merged.

@spitters
Copy link
Collaborator

spitters commented Jun 8, 2021

@maximedenes What is the status of this?

@spitters
Copy link
Collaborator

@maximedenes is this still relevant, or should we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants