Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #55
Changes
self.cmp
attributepre_computed_state
when callingformulation.composite_objective
method of the formulation.write_state
parameter offormulation.composite_objective
is a no-op whenformulation.cmp
isNone
Testing
A toy test was implemented (
tests/test_simplest_pipeline.py
) without a CMP or closure. This considers inequality constraints (not proxy) and a SimultaneousConstrainedOptimizer.Extrapolation and Alternating updates without a CMP are untested. Nonetheless, if a
closure
is provided to theirstep()
method, they should work.This is NOT breaking backwards compatibility. It is an alternative way for the user to use Cooper, but creating a CMP with a closure is still supported.
Docs
The changes in this PR have not been documented. Documentation is currently lagging behind code in dev branch (#53 #29).
I think that we could tackle all the issues with documentation in one go. For now, I propose to consider this PR without docs.