migration symfony 5 and 6 PHP 8.1 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Nov 8, 2023
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
3 times, most recently
from
b305b9f to
35daa05
Compare
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
from
c2b0739 to
8e690c5
Compare
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
from
8e690c5 to
2990eb0
Compare
dunglas
requested changes
Nov 14, 2023
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
from
2990eb0 to
22c03b9
Compare
|
Hi,
|
dunglas
requested changes
Nov 20, 2023
|
Did you try your changes locally? I just checked and it looks like SonataMediaBundle and FOSCKEditor bundles aren't compatible with Symfony 7 yet. As they are dependencies of this bundle, this bundle cannot be marked as compatible with Symfony 7 if SonataMediaBundle, FOSCKeditorBundle and probably others aren't upgraded before. Also, it looks like FOSCKEditorBundle doesn't support CKEditor 5, and that CKEditor 4 has been EOLed: FriendsOfSymfony/FOSCKEditorBundle#242 For this bundle to be useful, FOSCKeditorBundle must be made compatible with CKEditor 5. |
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
3 times, most recently
from
2b7a9b9 to
a2cba22
Compare
pauljosephkrogulec
changed the title
dunglas
requested changes
Nov 21, 2023
chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 chore: migration symfony 6 Co-authored-by: Kévin Dunglas <[email protected]> chore: migration symfony 6 Co-authored-by: Kévin Dunglas <[email protected]> chore: migration symfony 6 Co-authored-by: Kévin Dunglas <[email protected]>
pauljosephkrogulec
force-pushed
the
migration-symfony6
branch
from
db9759e to
f2188bf
Compare
dunglas
approved these changes
Nov 21, 2023
|
Thanks @pauljosephkrogulec |
dunglas
reviewed
Nov 21, 2023
| dependencies: | ||
| - "lowest" | ||
| - "highest" | ||
|
|
||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate php version for being able to be usable for symfony 6