-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add service: Shelve #4232
base: next
Are you sure you want to change the base?
Add service: Shelve #4232
Conversation
Please use https://coolify.io/docs/knowledge-base/docker/compose#coolifys-magic-environment-variables for the secrets if they should be random and also add FQDN to create a domain accessible via the proxy |
I've already looked at the 'magic-environment-variables' and I don't think any are necessary for my installation 🤔 @peaklabs-dev |
They are how would you access your app on port 3000 and should the NUXT_PRIVATE_ENCRYPTION_KEY and PASSWORD not be autogenerated? |
I consider this variable to be 'critical' and therefore must be filled in by the user, just like the variables for the github and google oauth 🤔 however, as for how the app will be accessed via port 3000, isn't this done via the docker-compose header? since I specified 3000 and the container only exposes port 3000. |
No, all secret vars should be auto-generated it uses secure function in the background so it is perfect for critical stuff, the port comment will probably be removed soon, all handled by the Coolify magic envs - you need something like SERVICE_SHELVE_FQDN_3000 in the envs as well. |
I've just pushed the desired changes, is this better? |
Shouldn't there be rules against this? |
I don't quite understand what the problem is? |
Perpetual maintenance of a service nobody will use other than yourself. |
I'm simply adding a template to the project, which will promote the adoption of my platform and which is already of interest to some people. The Coolify team will have no maintenance to do until proven otherwise. |
This project should (as soon as possible) start adding automated tests for every service. It is highly irresponsible to keep adding more services sans-tests. It is a large body of work, but that mountain only continues to grow as more services are added. Moreover, even the end-user suffers as a finely curated list is far more valuable to browse than a spaffpile of unpopular guff. The fact that you have no understanding of the cost of maintenance shows you're not an experienced maintainer. |
Changes
link of the service -> https://shelve.cloud
repo of the service -> https://github.com/HugoRCD/shelve