Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add registry auth to docker image apps #4187

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

chore: add registry auth to docker image apps #4187

wants to merge 1 commit into from
+116 −25

Conversation

OSINTRoach
Copy link

Changes

  • Added docker login and logout for docker images application with username and token/password input on frontend

Issues

  • fix #

@OSINTRoach
Copy link
Author

OSINTRoach commented Nov 8, 2024 •
edited
Loading

I would like some input on this, I have some questions ex:

  • Password/token is shown on debug logs, should it be like that
  • I have some problems with my local deployment on my mac so not fully tested, i have permission denied for mounts, and had problems with multiplexed (had to add IS_WINDOWS_DOCKER_DESKTOP=true even if i'm on mac for SSH_MUX_ENABLED=false to work)
  • Need to add registry urls

@OSINTRoach OSINTRoach marked this pull request as draft November 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OSINTRoach