Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deploy-only token permission #4067

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

KaelWD
Copy link

@KaelWD KaelWD commented Oct 30, 2024

Changes

  • Added a "Trigger Deploy Webhooks" permission that can only call api/v1/deploy

Issues

Might also be good to generate a secret for each resource instead of needing to create a token.

@KaelWD KaelWD marked this pull request as draft October 30, 2024 06:49
@KaelWD
Copy link
Author

KaelWD commented Oct 30, 2024

This doesn't work properly, laravel's auth middleware grants permissions but you're trying to use it to deny instead.

@KaelWD
Copy link
Author

KaelWD commented Oct 30, 2024

This could be made more granular too, maybe something like github's?
Screenshot_20241030_194215

@KaelWD KaelWD marked this pull request as ready for review November 3, 2024 07:58
@KaelWD KaelWD mentioned this pull request Nov 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant