Add XDebug config to support php debugging. #3818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # config/sentry.php # config/version.php # versions.json
Bilge
reviewed
Nov 7, 2024
| [xdebug] | ||
| zend_extension=xdebug.so | ||
| xdebug.mode=debug | ||
| xdebug.start_with_request=yes |
There was a problem hiding this comment.
Never do this. Allow the triggers to function as they should.
docker/dev/xdebug.ini
Outdated
| xdebug.mode=debug | ||
| xdebug.start_with_request=yes | ||
| xdebug.client_host=host.docker.internal | ||
| xdebug.client_port=9000 |
There was a problem hiding this comment.
Absolutely no reason to override the default. Since Xdebug 3, the default is 9003, for good reason (because 9000 conflicts with FPM and many other services).
docker/dev/xdebug.ini
Outdated
| @@ -0,0 +1,7 @@ | |||
| [xdebug] | |||
| zend_extension=xdebug.so | |||
| xdebug.mode=debug | |||
There was a problem hiding this comment.
This is a good start, but is also naive since it only supports debugging and not tracing or development helpers. I suggest this should be set to develop,debug for now, and develop,debug,trace once sane trace defaults are configured.
Bilge
reviewed
Nov 7, 2024
Co-authored-by: Bilge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes