Add rpm name search and integration testing #1
Conversation
rverdile
force-pushed
the
rpm-search
branch
11 times, most recently
from
d4b58fe
to
cbee8be
Compare
pkg/tangy/rpm.go
Outdated
| SELECT DISTINCT ON (rp.name) rp.name, rp.summary | ||
| FROM core_repositoryversion crv | ||
| INNER JOIN core_repository cr on crv.repository_id = cr.pulp_id | ||
| INNER JOIN core_repositorycontent crc on crv.pulp_id = crc.version_added_id |
There was a problem hiding this comment.
would version_added cause this to only be returned for the version that actually added the RPM?
There was a problem hiding this comment.
i think it would, so I changed it to
SELECT DISTINCT ON (rp.name) rp.name, rp.summary
FROM core_repositoryversion crv
INNER JOIN core_repository cr on crv.repository_id = cr.pulp_id
INNER JOIN core_repositorycontent crc on cr.pulp_id = crc.repository_id
INNER JOIN core_content cc on crc.content_id = cc.pulp_id
INNER JOIN rpm_package rp on cc.pulp_id = rp.content_ptr_id
WHERE CONCAT(crv.repository_id, '/', crv.number) = ANY ($1)
AND rp.name ILIKE CONCAT( '%', $2::text, '%')
There was a problem hiding this comment.
instead of trying to test manually, i updated your test to simulate re-syncing a repository to produce two different versions: https://gist.github.com/jlsherrill/5008aaee911029e74edb22dc014cd245
It all worked except when i search the first version after having created the second version, i seem to be getting the second version's results?
rverdile
force-pushed
the
rpm-search
branch
3 times, most recently
from
d70817d
to
40d1087
Compare
configs/config.yaml.example
Outdated
| # Configuration options for the pulp server | ||
| server: | ||
| url: "http://localhost:8087" | ||
| username: "pulp" |
There was a problem hiding this comment.
| username: "pulp" | |
| username: "admin" |
pkg/tangy/rpm.go
Outdated
| Summary string | ||
| } | ||
|
|
||
| func (t *tangyImpl) RpmRepositoryVersionPackageSearch(ctx context.Context, hrefs []string, search string) ([]RpmPackageSearch, error) { |
There was a problem hiding this comment.
i think we want this to take a limit, so we can expose that limit to the user like we do for rpms
| if dbConfig.PoolLimit == 0 { | ||
| dbConfig.PoolLimit = DefaultMaxPoolLimit | ||
| } | ||
| pxConfig.MaxConns = int32(dbConfig.PoolLimit) |
There was a problem hiding this comment.
we should probably have a method that would allow the application to close/release the connection pool
|
Also, would it make sense to include a Mock of the interface here? Instead of in our application. |
fix query add limit add close method add new test cases add mock Co-authored-by: Justin Sherrill <[email protected]>
|
updated |
|
|
||
| query += "UNION" | ||
| } | ||
| rows, err := conn.Query(context.Background(), query) |
There was a problem hiding this comment.
if you accidentally pass in an empty list, you end up getting a query error, it might be worth catching and just returning an empty list
There was a problem hiding this comment.
i think this is the last suggestion, otherwise looking good!
Summary
Adds
RpmRepositoryVersionPackageSearch(), to search RPMs by name given a list of repository hrefs.