Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Creating a volume and mounting it #843

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mayurilahane
Copy link
Contributor

Need to create and mount an empty directory inside the pod using a container.
So that you can upload any files from that directory or can use it as storage while testing if you download anything.

@mayurilahane mayurilahane changed the title Adding empty directory and mounting it Creating a volume and mounting it Oct 10, 2024
@jlsherrill jlsherrill changed the title Creating a volume and mounting it Build: Creating a volume and mounting it Oct 10, 2024
@jlsherrill
Copy link
Member

test failure doesn't look related?

@swadeley
Copy link
Member

test failure doesn't look related?

No it is not and that should be fixed now, I'll try a retest

@swadeley
Copy link
Member

/retest

@swadeley
Copy link
Member

Hi @mayurilahane, I see you added this to deployments/testing-integration.yaml

is this upload test only going to run in integration testing?

To use this in content-sources testing you need to add to deployments/deployment.yaml

@mayurilahane mayurilahane changed the title Build: Creating a volume and mounting it Draft: Creating a volume and mounting it Nov 19, 2024
@mayurilahane mayurilahane changed the title Draft: Creating a volume and mounting it Build: Creating a volume and mounting it Nov 19, 2024
@mayurilahane mayurilahane marked this pull request as draft November 19, 2024 09:01
@mayurilahane mayurilahane marked this pull request as ready for review December 6, 2024 11:29
Copy link
Member

@swadeley swadeley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@swadeley swadeley merged commit 18eb2c8 into content-services:main Dec 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants