Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimum-stability to stable #301

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Jan 8, 2017

Having a minimum-stability of dev greatly increases the memory consumption of the dependency resolving process. Since "regular" users likely will require only a minimum-stability of stable, the default should be set to stable in my opinion. Any advanced user surely will be able to change the setting accordingly.

@discordier
Copy link
Member

We can only do so in 0.17.0, as this will be a breaking change.

@discordier discordier added this to the 0.17.0 milestone Jan 12, 2017
@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 12, 2017

We can only do so in 0.17.0, as this will be a breaking change.

Since it can only affect new installations, it cannot break backwards compatibility, can it?

@discordier
Copy link
Member

It won't break old installations but will break news installations within a patch level of the extension.
New installations will behave differently then as they used to behave and therefore causing confusion I assume.

As we are still in the 0.x range, we can break stuff in the next minor, if we would already be in 1.x, we would have to wait for 2.x.

@fritzmg
Copy link
Contributor Author

fritzmg commented Jan 13, 2017

The increased memory requirement already causes confusion anyway. On the community forum I have to recommend to set that option to stable (which is the default value anyway) quite frequently.

@discordier
Copy link
Member

discordier commented Jan 13, 2017

Which will happen automatically in the next minor, as I wrote above.

Having a `minimum-stability` of `dev` greatly increases the memory consumption of the dependency resolving process. Since "regular" users likely will require only a `minimum-stability` of `stable`, the default should be set to `stable` in my opinion. Any advanced user surely will be able to change the setting accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants