Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add better detached mode support for Windows #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add better detached mode support for Windows #297

wants to merge 1 commit into from

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Oct 26, 2016

When running the detached mode in windows, the execution will wait until shell_exec is finished, thus you cannot monitor the live output.

This PR simply uses proc_open for windows instead.

@Toflar
Copy link
Contributor

Toflar commented Oct 26, 2016

Can't we use the Symfony Process component here?

@fritzmg
Copy link
Contributor Author

fritzmg commented Oct 26, 2016

Sounds good, I'll check it out.

@fritzmg
Copy link
Contributor Author

fritzmg commented Oct 26, 2016

Well, using symfony/process wouldn't really work, would it? The composer-client needs to be able to run as a standalone module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fritzmg @Toflar