Skip to content

Conversation

debarshiray
Copy link
Member

Checking the exit code, and the standard error and output streams of the
create command don't say anything about whether the container was
actually created. Therefore, podman ps --all is used to verify that.

Other tests already do this, so this change makes these tests consistent
with the rest.

@debarshiray debarshiray marked this pull request as draft September 8, 2025 12:57
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 8, 2025
@debarshiray debarshiray force-pushed the wip/rishi/test-system-create-check-with-podman-ps branch from 80646e8 to d40dd88 Compare September 8, 2025 12:58
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 8, 2025
Checking the exit code, and the standard error and output streams of the
'create' command don't say anything about whether the container was
actually created.  Therefore, 'podman ps --all' is used to verify that.

Other tests already do this, so this change makes these tests consistent
with the rest.

containers#1715
Copy link

@debarshiray debarshiray force-pushed the wip/rishi/test-system-create-check-with-podman-ps branch from d40dd88 to 6cc22af Compare September 8, 2025 14:25
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 8, 2025
Copy link

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Sep 8, 2025
@debarshiray debarshiray force-pushed the wip/rishi/test-system-create-check-with-podman-ps branch from 6cc22af to 9fbdac0 Compare September 8, 2025 16:01
@debarshiray debarshiray force-pushed the wip/rishi/test-system-create-check-with-podman-ps branch from 9fbdac0 to 8ffc9eb Compare September 8, 2025 16:16
Checking the exit code, and the standard error and output streams of the
'create' command don't say anything about whether the container was
actually created.  Therefore, 'podman ps --all' is used to verify that.

Other tests already do this, so this change makes these tests consistent
with the rest.

Fallout from the following:
  * b27795a
  * 983beb1
  * ecd1ced

containers#1715
Copy link

@debarshiray debarshiray marked this pull request as ready for review September 8, 2025 20:53
Copy link

@debarshiray debarshiray merged commit 4756370 into containers:main Sep 8, 2025
3 checks passed
@debarshiray debarshiray deleted the wip/rishi/test-system-create-check-with-podman-ps branch September 8, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant