build: Bump NVIDIA Container Toolkit to 1.17.3 #1614
Conversation
The src/go.sum file was updated with 'go mod tidy'. containers#1614
debarshiray
force-pushed
the
wip/rishi/github.com-NVIDIA-nvidia-container-toolkit-1.17.3
branch
from
5482d56 to
957601f
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 15s |
The src/go.sum file was updated with 'go mod tidy'. containers#1614
|
Build failed. ✔️ unit-test SUCCESS in 5m 09s |
|
recheck |
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 34s |
... for CVE-2024-0134 or GHSA-7jm9-xpwx-v999. The src/go.sum file was updated with 'go mod tidy'. containers#1614
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 22s |
... for CVE-2024-0134 or GHSA-7jm9-xpwx-v999. NVIDIA Container Toolkit 1.17.0 requires Go >= 1.21, even though it's not mentioned in its go.mod file [1]. The src/go.sum file was updated with 'go mod tidy'. [1] NVIDIA/nvidia-container-toolkit#886 containers#1614
The src/go.sum file was updated with 'go mod tidy'. containers#1614
debarshiray
force-pushed
the
wip/rishi/github.com-NVIDIA-nvidia-container-toolkit-1.17.3
branch
from
855a811 to
82e85ba
Compare
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 33s |
|
Thanks for the review, @Jmennius |
The src/go.sum file was updated with 'go mod tidy'. containers#1614
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 19s |
... for CVE-2024-0135 or GHSA-9v84-cc9j-pxr6, CVE-2024-0136 or GHSA-vcfp-63cx-4h59, and CVE-2024-0137 or GHSA-frhw-w3wm-6cw4. The src/go.sum file was updated with 'go mod tidy'. containers#1614
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 19s |
|
Build succeeded. ✔️ unit-test SUCCESS in 5m 21s |
debarshiray
deleted the
wip/rishi/github.com-NVIDIA-nvidia-container-toolkit-1.17.3
branch
The os.IsNotExist() function [1] predates the introduction of the errors.Is() function [2] in Go 1.13 [3]. From Go >= 1.16, the documentation explicitly recommends the use of errors.Is() instead of os.IsNotExist() [4]. The Go implementation of Toolbx never used any Go older than 1.13 [5], and currently it requires Go >= 1.21 [6]. So, there's no reason not to use the more modern and recommended alternative. [1] https://pkg.go.dev/os#IsNotExist [2] https://pkg.go.dev/errors#Is [3] https://go.dev/blog/go1.13-errors [4] Go commit b641f0dcf48aa748 golang/go@b641f0dcf48aa748 golang/go#41122 [5] Commit d857471 containers@d857471aa2f233e5 containers#318 [6] Commit 82e85ba containers@82e85bac9f5e69a5 containers#1614
The os.IsNotExist() function [1] predates the introduction of the errors.Is() function [2] in Go 1.13 [3]. From Go >= 1.16, the documentation explicitly recommends the use of errors.Is() instead of os.IsNotExist() [4]. The Go implementation of Toolbx never used any Go older than 1.13 [5], and currently it requires Go >= 1.21 [6]. So, there's no reason not to use the more modern and recommended alternative. [1] https://pkg.go.dev/os#IsNotExist [2] https://pkg.go.dev/errors#Is [3] https://go.dev/blog/go1.13-errors [4] Go commit b641f0dcf48aa748 golang/go@b641f0dcf48aa748 golang/go#41122 [5] Commit d857471 containers@d857471aa2f233e5 containers#318 [6] Commit 82e85ba containers@82e85bac9f5e69a5 containers#1614 containers#1629
The os.IsNotExist() function [1] predates the introduction of the errors.Is() function [2] in Go 1.13 [3]. From Go >= 1.16, the documentation explicitly recommends the use of errors.Is() instead of os.IsNotExist() [4]. The Go implementation of Toolbx never used any Go older than 1.13 [5], and currently it requires Go >= 1.21 [6]. So, there's no reason not to use the more modern and recommended alternative. [1] https://pkg.go.dev/os#IsNotExist [2] https://pkg.go.dev/errors#Is [3] https://go.dev/blog/go1.13-errors [4] Go commit b641f0dcf48aa748 golang/go@b641f0dcf48aa748 golang/go#41122 [5] Commit d857471 containers@d857471aa2f233e5 containers#318 [6] Commit 82e85ba containers@82e85bac9f5e69a5 containers#1614 containers#1629
The
src/go.sumfile was updated withgo mod tidy.