test/system: Simplify code #1412
Conversation
There's no need to run these cat(1) and gdbus(1) invocations through a shell (ie., 'sh -c'), because there's no shell expansion that needs to be performed. These are unlike cases where shell expansion does need to be performed. eg., 'readlink /proc/$$/ns/user', where the $$ needs to be expanded. Fallout from 58134f8 and a0514cb containers#1412
debarshiray
force-pushed
the
wip/rishi/test-system-user-dbus-simplify-remove-sh-c
branch
from
e71c057 to
a50cc17
Compare
There's no need to run these cat(1) and gdbus(1) invocations through a shell (ie., 'sh -c'), because there's no shell expansion that needs to be performed. These are unlike cases where shell expansion does need to be performed. eg., 'readlink /proc/$$/ns/user', where the $$ needs to be expanded. Fallout from 58134f8 and a0514cb containers#1412
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 08s |
debarshiray
force-pushed
the
wip/rishi/test-system-user-dbus-simplify-remove-sh-c
branch
from
a50cc17 to
532e846
Compare
The arguments for the D-Bus method are accepted separately by gdbus(1) without any options. Therefore, they shouldn't be indented by another additional level. containers#1412
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 11s |
|
Build succeeded. ✔️ unit-test SUCCESS in 9m 14s |
debarshiray
deleted the
wip/rishi/test-system-user-dbus-simplify-remove-sh-c
branch
There's no need to run these cat(1) and gdbus(1) invocations through a shell (ie., 'sh -c'), because there's no shell expansion that needs to be performed.
These are unlike cases where shell expansion does need to be performed. eg., 'readlink /proc/$$/ns/user', where the $$ needs to be expanded.
Fallout from 58134f8 and a0514cb