support copy multi arch instance #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cleverhu <[email protected]>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mtrmac
requested changes
Oct 29, 2024
| // There is no CopyNoImages value in copy.ImageListSelection, but because we | ||
| // don't provide an option to select a set of images to copy, we can use | ||
| // CopySpecificImages. | ||
| case "index-only": |
There was a problem hiding this comment.
We must not break existing options.
Comment on lines
+129
to
+135
| // case "index-only": | ||
| // return copy.CopySpecificImages, nil | ||
| // // We don't expose CopySpecificImages other than index-only above, because | ||
| // // we currently don't provide an option to choose the images to copy. That | ||
| // // could be added in the future. | ||
| // default: | ||
| // return copy.CopySystemImage, fmt.Errorf("unknown multi-arch option %q. Choose one of the supported options: 'system', 'all', or 'index-only'", multiArch) |
There was a problem hiding this comment.
Ultimately, code should be removed, unless it is relevant for future readers. Git preserves the history anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support copy multi arch instance, this PR must work with containers/image#2612