Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support copy multi arch instance #2445

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

cleverhu
Copy link

@cleverhu cleverhu commented Oct 28, 2024

support copy multi arch instance, this PR must work with containers/image#2612

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Similarly to c/image, all existing options must keep working.

Also compare previous #1987, that probably discusses relevant concerns; I didn’t now go back to re-read that.

// There is no CopyNoImages value in copy.ImageListSelection, but because we
// don't provide an option to select a set of images to copy, we can use
// CopySpecificImages.
case "index-only":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must not break existing options.

Comment on lines +129 to +135
// case "index-only":
// return copy.CopySpecificImages, nil
// // We don't expose CopySpecificImages other than index-only above, because
// // we currently don't provide an option to choose the images to copy. That
// // could be added in the future.
// default:
// return copy.CopySystemImage, fmt.Errorf("unknown multi-arch option %q. Choose one of the supported options: 'system', 'all', or 'index-only'", multiArch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ultimately, code should be removed, unless it is relevant for future readers. Git preserves the history anyway.

@mtrmac mtrmac added the kind/feature A request for, or a PR adding, new functionality label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for, or a PR adding, new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants