Begin process of packaging PRAGmatic #597

rhatdan · 2025-01-16T22:19:12Z

Building Pragmatic into a container image is fairly easy.

podman build --build-arg IMAGE=quay.io/ramalama/rocm -t quay.io/ramalama/rocm-rag container-images/pragmatic

Summary by Sourcery

Build:

Install Python and the PRAGmatic package.

sourcery-ai · 2025-01-16T22:19:17Z

Reviewer's Guide by Sourcery

This pull request adds the initial setup for packaging the PRAGmatic library. It clones the PRAGmatic repository, installs its dependencies, and installs the library itself. It also adds python as an install dependency.

Sequence diagram for PRAGmatic build and installation process

sequenceDiagram
    participant S as Script
    participant DNF as Package Manager
    participant Git as Git
    participant Pip as Pip
    S->>DNF: Install Python
    S->>Git: Clone PRAGmatic repository
    S->>Git: Initialize submodules
    S->>Pip: Install requirements
    S->>Pip: Install PRAGmatic package
    S->>S: Cleanup

Flow diagram for build script modifications

flowchart TD
    A[Start] --> B[DNF Install]
    B --> C[Install Python]
    C --> D[Clone PRAGmatic]
    D --> E[Update Submodules]
    E --> F[Install Requirements]
    F --> G[Install PRAGmatic]
    G --> H[Build Whisper.cpp]
    H --> I[Build Llama.cpp]
    I --> J[Cleanup]
    J --> K[End]

File-Level Changes

Change	Details	Files
Added steps to clone, build, and install the PRAGmatic library.	Cloned the PRAGmatic repository. Installed the Python dependencies of PRAGmatic. Installed the PRAGmatic library. Added `python` to the list of installed dependencies Removed the PRAGmatic directory in the cleanup phase of the script to avoid leaving unnecessary files in the image.	`container-images/scripts/build_llama_and_whisper.sh`
Updated the cleanup phase to remove the PRAGmatic directory.	Removed the PRAGmatic directory after the build process is complete to ensure a clean image.	`container-images/scripts/build_llama_and_whisper.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

rhatdan · 2025-01-16T22:19:37Z

This could get painful:
$ podman images
REPOSITORY TAG IMAGE ID CREATED SIZE
quay.io/ramalama/ramalama latest 4c2e061e2975 7 minutes ago 10.5 GB

sourcery-ai

Hey @rhatdan - I've reviewed your changes - here's some feedback:

Overall Comments:

Since this is marked as WIP, please clarify in the PR description what work is still pending and what the current limitations are.
Consider using a virtual environment for pip installations instead of installing directly to /usr, or document why this specific approach is necessary.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

ericcurtin · 2025-01-16T22:33:42Z

container-images/scripts/build_llama_and_whisper.sh

@@ -94,6 +95,18 @@ clone_and_build_llama_cpp() {
  cd ..
 }

+clone_and_build_pragmatic() {
+  local llama_cpp_sha="924518e2e5726e81f3aeb2518fb85963a500e93a"


Unused stuff could be cleaned up here

ericcurtin · 2025-01-27T09:52:19Z

container-images/pragmatic/build_pragmatic.sh

@@ -0,0 +1,22 @@
+#!/bin/bash
+
+clone_and_build_pragmatic() {


We should add

set -exu -o pipefail

We want the build to fail if these commands fail.

Ok, I am still working on making the install smaller. Gotten CPU cut in 1/3 but little change in ROCM and CUDA.

Should we add the same flag to build_llama_and_whisper.sh?

set -ex is there, it's just in the main function (we could add, -o pipefail, etc. if it suits). I tend to create main functions in shell scripts to encourage using scope and less global variable.

set -e alone covers a lot to be fair sometimes it's sufficient.

I do like to add -x at times also, makes CI easy to debug.

But set -e at least is a good idea.

dougsland · 2025-01-30T05:31:57Z

container-images/pragmatic/build_pragmatic.sh

+
+export  PYTHON_VERSION="python3 -m"
+if [ "$(python3 --version)" \< "Python 3.11" ]; then
+    dnf install -y python3.11 python3.11-pip


Question, python3.12 and python3.13 are not supported? Still learning these bits.

They are supported, this is just checking for RHEL 9 systems with python 3.9. Basically ramalama requires 3.11 or later.

rhatdan · 2025-02-05T18:31:33Z

@ericcurtin @bmahabirbu this is ready to go in. It does not build anything yet, just allows people to build RAG Models layers on top of our images. Once this is in, we can start experimenting with using RAG with RamaLama.

Building Pragmatic into a container image is fairly easy. podman build --build-arg IMAGE=quay.io/ramalama/rocm -t quay.io/ramalama/rocm-rag container-images/pragmatic Signed-off-by: Daniel J Walsh <[email protected]>

ericcurtin · 2025-02-05T19:16:39Z

@bmahabirbu feel free to review and merge, I'll probably be offline soon (if the builds pass of course).

Fedora 42 build can be ignored, would love to turn that off as it's unstable (Fedora 42 isn't even released).

bmahabirbu · 2025-02-05T21:48:04Z

@rhatdan thanks for merging! Will play around with this this week!

rhatdan · 2025-02-08T11:04:02Z

Here is the lastest stuff I am working on for creation of the vector.db

#501

rhatdan · 2025-02-08T11:04:39Z

I also just got this merged: redhat-et/PRAGmatic#39

sourcery-ai bot reviewed Jan 16, 2025

View reviewed changes

ericcurtin reviewed Jan 16, 2025

View reviewed changes

rhatdan force-pushed the pragmatic branch 10 times, most recently from 2fe8b8e to b04281b Compare January 23, 2025 17:56

rhatdan changed the title ~~[WIP] Begin process of packaging PRAGmatic~~ Begin process of packaging PRAGmatic Jan 23, 2025

ericcurtin approved these changes Jan 27, 2025

View reviewed changes

ericcurtin reviewed Jan 27, 2025

View reviewed changes

rhatdan force-pushed the pragmatic branch from b04281b to 1e17bb9 Compare January 27, 2025 16:33

dougsland reviewed Jan 30, 2025

View reviewed changes

rhatdan force-pushed the pragmatic branch from 1e17bb9 to fb06285 Compare February 5, 2025 18:20

rhatdan requested review from bmahabirbu, maxamillion, swarajpande5, jhjaggars, cgruver, slp and engelmi as code owners February 5, 2025 18:20

rhatdan force-pushed the pragmatic branch from fb06285 to 97c3dcb Compare February 5, 2025 18:30

rhatdan force-pushed the pragmatic branch from 97c3dcb to 64d4e0f Compare February 5, 2025 18:39

Begin process of packaging PRAGmatic

c166c0a

Building Pragmatic into a container image is fairly easy. podman build --build-arg IMAGE=quay.io/ramalama/rocm -t quay.io/ramalama/rocm-rag container-images/pragmatic Signed-off-by: Daniel J Walsh <[email protected]>

rhatdan force-pushed the pragmatic branch from 64d4e0f to c166c0a Compare February 5, 2025 19:08

ericcurtin approved these changes Feb 5, 2025

View reviewed changes

rhatdan merged commit 032efae into containers:main Feb 5, 2025
16 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Begin process of packaging PRAGmatic #597

Begin process of packaging PRAGmatic #597

rhatdan commented Jan 16, 2025 •

edited

Loading

sourcery-ai bot commented Jan 16, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

rhatdan commented Jan 16, 2025

sourcery-ai bot left a comment

ericcurtin Jan 16, 2025

ericcurtin Jan 27, 2025

rhatdan Jan 27, 2025

rhatdan Jan 27, 2025

ericcurtin Jan 27, 2025

dougsland Jan 30, 2025

rhatdan Jan 30, 2025

rhatdan commented Feb 5, 2025

ericcurtin commented Feb 5, 2025

bmahabirbu commented Feb 5, 2025 •

edited

Loading

rhatdan commented Feb 8, 2025

rhatdan commented Feb 8, 2025

		@@ -0,0 +1,22 @@
		#!/bin/bash

		clone_and_build_pragmatic() {

Begin process of packaging PRAGmatic #597

Begin process of packaging PRAGmatic #597

Conversation

rhatdan commented Jan 16, 2025 • edited Loading

Summary by Sourcery

sourcery-ai bot commented Jan 16, 2025 • edited Loading

Reviewer's Guide by Sourcery

Sequence diagram for PRAGmatic build and installation process

Flow diagram for build script modifications

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

rhatdan commented Jan 16, 2025

sourcery-ai bot left a comment

Choose a reason for hiding this comment

ericcurtin Jan 16, 2025

Choose a reason for hiding this comment

ericcurtin Jan 27, 2025

Choose a reason for hiding this comment

rhatdan Jan 27, 2025

Choose a reason for hiding this comment

rhatdan Jan 27, 2025

Choose a reason for hiding this comment

ericcurtin Jan 27, 2025

Choose a reason for hiding this comment

dougsland Jan 30, 2025

Choose a reason for hiding this comment

rhatdan Jan 30, 2025

Choose a reason for hiding this comment

rhatdan commented Feb 5, 2025

ericcurtin commented Feb 5, 2025

bmahabirbu commented Feb 5, 2025 • edited Loading

rhatdan commented Feb 8, 2025

rhatdan commented Feb 8, 2025

rhatdan commented Jan 16, 2025 •

edited

Loading

sourcery-ai bot commented Jan 16, 2025 •

edited

Loading

bmahabirbu commented Feb 5, 2025 •

edited

Loading