add artifact validation during container creation #27793
+112
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
MayorFaj
force-pushed
the
fix-artifact-validation-27747
branch
from
c9cce5f to
558c1b0
Compare
Validate artifact mounts exist at container creation time instead of start time. This prevents creation of containers that can never start due to missing artifacts, providing immediate feedback with clear error messages. Fixes: containers#27747 Signed-off-by: MayorFaj <[email protected]>
MayorFaj
force-pushed
the
fix-artifact-validation-27747
branch
from
7ef0da3 to
ed3c92d
Compare
Signed-off-by: MayorFaj <[email protected]>
Honny1
requested changes
Dec 22, 2025
|
|
||
| // validateArtifactVolumes checks that all artifacts exist and are accessible | ||
| // at container creation time, preventing creation of containers that can never start. | ||
| func validateArtifactVolumes(ctx context.Context, rt *libpod.Runtime, artifactVolumes []*specgen.ArtifactVolume) error { |
Member
There was a problem hiding this comment.
I believe this function can be repurposed for start containers.
Contributor
Author
There was a problem hiding this comment.
good suggestion. would it be ideal to implement that in this PR, or create a followup PR ?
Contributor
Author
There was a problem hiding this comment.
the latest changes has this update now
…ation utility Signed-off-by: MayorFaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?
Fixes #27747