[play_kube] Add validation to container image field #27791
Merged
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
ninja-quokka
force-pushed
the
kube_play_image_validation
branch
2 times, most recently
from
0c395e9 to
9883465
Compare
Honny1
reviewed
Dec 17, 2025
| var podWithoutAnImage = ` | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| spec: |
Member
There was a problem hiding this comment.
Suggested change
| spec: | |
| metadata: | |
| name: my-pod-name # <--- This is missing | |
| labels: | |
| app: my-app | |
| spec: |
mheon
reviewed
Dec 17, 2025
test/e2e/play_kube_test.go
Outdated
| err := writeYaml(podWithoutAnImage, kubeYaml) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| kube := podmanTest.PodmanExitCleanly("kube", "play", kubeYaml) |
Member
There was a problem hiding this comment.
PodmanExitCleanly will fail here because we expect no error; just podmanTest.Podman will work better
ninja-quokka
force-pushed
the
kube_play_image_validation
branch
from
9883465 to
85e3bf2
Compare
Fixes: containers#27784 Signed-off-by: Lewis Denny <[email protected]>
ninja-quokka
force-pushed
the
kube_play_image_validation
branch
from
85e3bf2 to
74c0795
Compare
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27784
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?