Fix(quadlet): Ensure .app application file is removed by quadlet rm --all (#27647) #27694

kavishgr · 2025-12-05T08:19:49Z

Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
the sign-off email address. See CONTRIBUTING.md
for more information.
Referenced issues using Fixes: #00000 in commit message (if applicable)
Tests have been added/updated (or no tests are needed)
Documentation has been updated (or no documentation changes are needed)
All commits pass make validatepr (format/lint checks)
Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

Fixes: #27647

Note on Dependencies:

This PR is dependent on the changes from issue #27653, as outlined in PR #27693. Once #27693 merges, I will rebase and push the changes here.

What I did (quadlet.go file):

Fixed reverseMap lookup by using the base filename instead of the full path, since reverseMap keys are filenames only
Added conditional path handling when expanding quadlets from .app files - use full paths when --all flag is set (since getAllQuadletPaths returns full paths), but use just filenames otherwise (since getQuadletPathByName expects filenames)
Moved the cleanup of .app and .asset metadata files outside the main quadlet removal loop. Previously these files were being left behind because they aren't included in allQuadletPaths. Now they're properly removed after all quadlets have been processed
Added logging for the files being removed

These changes fix the issue where .app files were not being deleted during removal(podman quadlet --all --force), and also resolve path resolution errors when removing individual apps (e.g., podman quadlet rm .nginx-test.app).

Test:

The test verifies that the podman quadlet rm -af command correctly removes all quadlet files.

openshift-ci · 2025-12-05T08:19:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kavishgr
Once this PR has been reviewed and has the lgtm label, please assign honny1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Honny1

I did a quick check of the CI failure. I also fixed the release note format in the PR description.

Honny1 · 2025-12-05T13:40:19Z

pkg/domain/infra/abi/quadlet.go


+// addIfUnique appends item to list if it has not already been seen in seenMap.
+// it returns true if the item was newly added, false if it was already present.
+func addIfUnique(seenMap map[string]struct{}, item string, list *[]string) bool {


pkg/domain/infra/abi/quadlet.go:758:76: addIfUnique - result 0 (bool) is never used (unparam) func addIfUnique(seenMap map[string]struct{}, item string, list *[]string) bool { ^ 1 issues: * unparam: 1

…s#27653) Fix: removed return statement, which was originally added for logging. Logrus handles the logging(in its related PR containers#27694). Signed-off-by: Kavish Gour <[email protected]>

kavishgr · 2025-12-08T04:15:01Z

This PR now includes all necessary changes. We should abandon PR #27693 and only merge this current one.

Honny1

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

kavishgr · 2025-12-08T14:55:20Z

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

On a closed PR regarding quadlets, a collaborator suggested that all quadlet tests should go into 36-quadlets.at. I think I might’ve misunderstood that, sorry about the mix up. I can write it in Ginkgo. I recently ran one and it passed. I can implement the rm -af tests using Podman commands, and we can keep the Libpod API test as it is

ygalblum

Small nit

ygalblum · 2025-12-08T15:30:47Z

test/apiv2/36-quadlets.at

+#
+# Install quadlets(.container, .network, .volume)
+
+quadlet_name=quadlet-rm-test-$(cat /proc/sys/kernel/random/uuid)


Use safename (defined in helpers.bash)

Got it. Thanks.

Sorry, my bad, I though this was a bats test. I'm not sure this one has the safename

No worries. I've updated the test name to quadlet-remove-all-test to keep it consistent.

Honny1 · 2025-12-08T15:40:18Z

The code LGTM. However, I have a question about the tests: is there a specific reason they weren't implemented in quadlet_test.go?

On a closed PR regarding quadlets, a collaborator suggested that all quadlet tests should go into 36-quadlets.at. I think I might’ve misunderstood that, sorry about the mix up. I can write it in Ginkgo. I recently ran one and it passed. I can implement the rm -af tests using Podman commands, and we can keep the Libpod API test as it is

Yes, please write a simple test in Ginkgo.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

packit-as-a-service · 2025-12-08T18:33:11Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1 · 2025-12-09T10:12:58Z

test/e2e/quadlet_test.go

+
+	Describe("Running quadlet force remove all", func() {
+		It("Should remove all quadlets at once", func() {
+			quadletName := fmt.Sprintf("quadlet-remove-all-test-%d", GinkgoRandomSeed())


This should be skipped on remote.

SkipIfRemote("quadlet is not supported for remote clients")

Honny1

LGTM, please rebase on main.

kavishgr · 2025-12-18T16:21:35Z

LGTM, please rebase on main.

Done. Rebased on latest main.

Honny1 · 2025-12-22T11:00:17Z

test/e2e/quadlet_test.go

+
+			installSession := podmanTest.Podman([]string{"quadlet", "install", tmpDir})
+			installSession.WaitWithDefaultTimeout()
+			Expect(installSession).Should(Exit(0))


This still fails on F43. I am not sure where the problem could be.

[FAIL] quadlet system generator Running quadlet force remove all [It] Should remove all quadlets at once [+0894s] /var/tmp/go/src/github.com/containers/podman/test/e2e/quadlet_test.go:1360

I ran the tests and they passed on my end. Here is the output:

❯ sudo ginkgo -v -focus "Running quadlet force remove all" test/e2e Running Suite: Libpod Suite - /home/kavish/podman/test/e2e ========================================================== Random Seed: 1766421735 Will run 1 of 2443 specs ------------------------------ [SynchronizedBeforeSuite] /home/kavish/podman/test/e2e/common_test.go:169 [image already cached: /var/tmp/quay.io-libpod-cirros-latest.tar] [image already cached: /var/tmp/quay.io-libpod-volume-plugin-test-img-20220623.tar] [image already cached: /var/tmp/quay.io-libpod-alpine-latest.tar] [image already cached: /var/tmp/quay.io-libpod-busybox-latest.tar] [image already cached: /var/tmp/quay.io-libpod-systemd-image-20240124.tar] [image already cached: /var/tmp/quay.io-lsm5-alpine_nginx-aarch64-latest.tar] [image already cached: /var/tmp/quay.io-libpod-redis-alpine.tar] [image already cached: /var/tmp/quay.io-libpod-registry-2.8.2.tar] [image already cached: /var/tmp/quay.io-libpod-k8s-pause-3.5.tar] [image already cached: /var/tmp/quay.io-libpod-testimage-20241011.tar] [image already cached: /var/tmp/quay.io-libpod-alpine_healthcheck-latest.tar] [image already cached: /var/tmp/quay.io-libpod-systemd-image-20240124.tar] Restoring quay.io/libpod/alpine:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-alpine-latest.tar Loaded image: quay.io/libpod/alpine:latest Restoring quay.io/libpod/busybox:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-busybox-latest.tar Loaded image: quay.io/libpod/busybox:latest Restoring quay.io/libpod/systemd-image:20240124... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-systemd-image-20240124.tar Loaded image: quay.io/libpod/systemd-image:20240124 Restoring quay.io/lsm5/alpine_nginx-aarch64:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-lsm5-alpine_nginx-aarch64-latest.tar Loaded image: quay.io/lsm5/alpine_nginx-aarch64:latest Restoring quay.io/libpod/redis:alpine... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-redis-alpine.tar Loaded image: quay.io/libpod/redis:alpine Restoring quay.io/libpod/registry:2.8.2... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-registry-2.8.2.tar Loaded image: quay.io/libpod/registry:2.8.2 Restoring quay.io/libpod/k8s-pause:3.5... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-k8s-pause-3.5.tar Loaded image: quay.io/libpod/k8s-pause:3.5 Restoring quay.io/libpod/testimage:20241011... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-testimage-20241011.tar Loaded image: quay.io/libpod/testimage:20241011 Restoring quay.io/libpod/alpine_healthcheck:latest... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-alpine_healthcheck-latest.tar Loaded image: quay.io/libpod/alpine_healthcheck:latest Restoring quay.io/libpod/systemd-image:20240124... Running: /home/kavish/podman/bin/podman --root /tmp/podman-e2e-554133839/imagecachedir --runroot /tmp/podman-e2e-554133839/image-init/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/image-init --events-backend none --storage-driver overlay load -q -i /var/tmp/quay.io-libpod-systemd-image-20240124.tar Loaded image: quay.io/libpod/systemd-image:20240124 ----------------------------- [SynchronizedBeforeSuite] PASSED [3.831 seconds] ------------------------------ SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS ------------------------------ quadlet system generator Running quadlet force remove all Should remove all quadlets at once /home/kavish/podman/test/e2e/quadlet_test.go:1339 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet install /tmp/podman-e2e-554133839/subtest-3789943928/p/quadlet-remove-all-test-1766421735 /etc/containers/systemd/quadlet-remove-all-test-1766421735.volume /etc/containers/systemd/quadlet-remove-all-test-1766421735.container /etc/containers/systemd/quadlet-remove-all-test-1766421735.network Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet list --format json [ { "Name": "quadlet-remove-all-test-1766421735.container", "UnitName": "quadlet-remove-all-test-1766421735.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.container", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" }, { "Name": "quadlet-remove-all-test-1766421735.network", "UnitName": "quadlet-remove-all-test-1766421735-network.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.network", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" }, { "Name": "quadlet-remove-all-test-1766421735.volume", "UnitName": "quadlet-remove-all-test-1766421735-volume.service", "Path": "/etc/containers/systemd/quadlet-remove-all-test-1766421735.volume", "Status": "inactive/dead", "App": ".quadlet-remove-all-test-1766421735.app" } ] Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet rm -af quadlet-remove-all-test-1766421735.container quadlet-remove-all-test-1766421735.network quadlet-remove-all-test-1766421735.volume Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay quadlet list --format json [] Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay stop --all -t 0 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay pod rm -fa -t 0 Running: /home/kavish/podman/bin/podman --storage-opt overlay.imagestore=/tmp/podman-e2e-554133839/imagecachedir --root /tmp/podman-e2e-554133839/subtest-3789943928/p/root --runroot /tmp/podman-e2e-554133839/subtest-3789943928/p/runroot --runtime crun --conmon /usr/bin/conmon --network-config-dir /etc/containers/networks --network-backend netavark --cgroup-manager systemd --tmpdir /tmp/podman-e2e-554133839/subtest-3789943928/p --events-backend file --storage-driver overlay rm -fa -t 0 • [0.578 seconds] ------------------------------ SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS ------------------------------ [SynchronizedAfterSuite] /home/kavish/podman/test/e2e/common_test.go:235 integration timing results quadlet system generator Running quadlet force remove all Should remove all quadlets at once 0.523858 [SynchronizedAfterSuite] PASSED [0.177 seconds] ------------------------------ Ran 1 of 2443 Specs in 4.624 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 2442 Skipped PASS Ginkgo ran 1 suite in 8.290264111s Test Suite Passed

I also verified this against the latest main branch, and it passed there as well. Even with sudo ginkgo run -v --focus-file=quadlet_test.go test/e2e/, it’s still passing:

OUTPUT REDACTED quadlet system generator Running success quadlet test case logopt.container 0.013379 quadlet system generator Running success quadlet test case label.container 0.013625 quadlet system generator Running success quadlet test case exec.container 0.013705 quadlet system generator Running success quadlet test case pull.container 0.013814 quadlet system generator Running success quadlet test case readonly-notmpfs.container 0.014216 quadlet system generator Running success quadlet test case capabilities.container 0.014951 quadlet system generator Running quadlet force remove all Should remove all quadlets at once 0.503787 [SynchronizedAfterSuite] PASSED [0.175 seconds] ------------------------------ Ran 301 of 2443 Specs in 26.713 seconds SUCCESS! -- 301 Passed | 0 Failed | 0 Pending | 2142 Skipped PASS Ginkgo ran 1 suite in 31.515989818s Test Suite Passed

I'm not sure why it's failing.

I noticed the test was using Exit(0) in several places. I've updated it to use ExitCleanly() instead, which is the recommended Ginkgo matcher. This might resolve the F43 failure. I will push soon and see what's up.

Update: Done.

…s#27653) Refactor removelist into sets Add quadlet rm --all test with safename add an integration test for quadlet rm --all(skip for remote clients) Signed-off-by: Kavish Gour <[email protected]>

openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Dec 5, 2025

kavishgr mentioned this pull request Dec 5, 2025

Fix(quadlet): Deduplicate removal files for .app expansion (#27653) #27693

Closed

6 tasks

Honny1 reviewed Dec 5, 2025

View reviewed changes

openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Dec 5, 2025

kavishgr force-pushed the fix/issue-27647 branch from c299e69 to 40f3bff Compare December 5, 2025 17:03

Honny1 reviewed Dec 8, 2025

View reviewed changes

ygalblum reviewed Dec 8, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch 2 times, most recently from 7583fd1 to bc3a8f0 Compare December 8, 2025 18:32

kavishgr force-pushed the fix/issue-27647 branch from bc3a8f0 to 01fb0bc Compare December 8, 2025 18:42

Honny1 reviewed Dec 9, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch from 01fb0bc to 55c16c1 Compare December 9, 2025 15:11

Honny1 approved these changes Dec 17, 2025

View reviewed changes

kavishgr force-pushed the fix/issue-27647 branch from 55c16c1 to 06ccfe0 Compare December 18, 2025 16:18

Honny1 reviewed Dec 22, 2025

View reviewed changes

Fix(quadlet): Deduplicate removal files for .app expansion (container…

cf9f56d

…s#27653) Refactor removelist into sets Add quadlet rm --all test with safename add an integration test for quadlet rm --all(skip for remote clients) Signed-off-by: Kavish Gour <[email protected]>

kavishgr force-pushed the fix/issue-27647 branch from 06ccfe0 to cf9f56d Compare December 23, 2025 04:28

Fix(quadlet): Ensure .app application file is removed by quadlet rm --all (#27647) #27694

Are you sure you want to change the base?

Fix(quadlet): Ensure .app application file is removed by quadlet rm --all (#27647) #27694

Conversation

kavishgr commented Dec 5, 2025 • edited by Honny1 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this PR introduce a user-facing change?

Uh oh!

openshift-ci bot commented Dec 5, 2025

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kavishgr commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

kavishgr commented Dec 8, 2025

Uh oh!

ygalblum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Honny1 commented Dec 8, 2025

Uh oh!

packit-as-a-service bot commented Dec 8, 2025

Uh oh!

packit-as-a-service bot commented Dec 8, 2025

Uh oh!

packit-as-a-service bot commented Dec 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Honny1 left a comment

Choose a reason for hiding this comment

Uh oh!

kavishgr commented Dec 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kavishgr Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kavishgr commented Dec 5, 2025 •

edited by Honny1

Loading

kavishgr commented Dec 8, 2025 •

edited

Loading

kavishgr Dec 23, 2025 •

edited

Loading