Skip to content

Conversation

kcrocombe
Copy link

Existing integration test cases for farm functionality is limited to the operations that create/update/delete farm objects. There is no test coverage of any actual farm builds.

This submission seeks to address this via the addition of a new integration test module: farm_build_test.go

This module:

  • prepares a simulated, multi-farm, multi-node test environment
  • performs testing of the podman farm build function across that environment.
  • confirms that the expected number of builds are performed; that they are of the correct architecture; and that they built on the expected nodes, as determined by the supplied parameters.

The commit also includes two minor changes:

  • A very minor change the farm documention to clarify one of of the default setting.

  • The farm system-test script 001-farm.bats now uses an explicitly set connection name rather than relying on the default in the users environment being set in a supportive manner.

THIS SUBMISSION MAKES NO CHANGES TO THE PRODUCT CODE BASE.

Does this PR introduce a user-facing change?

None

Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

"os"
"os/exec"
"slices"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the three stanzas can be grouped as one

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I've never written Go before, so any style tips, pointers etc. gratefully received.

"strings"
"time"

"github.com/onsi/gomega/types"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@github-actions github-actions bot added machine kind/api-change Change to remote API; merits scrutiny labels Sep 2, 2025
@kcrocombe kcrocombe force-pushed the main branch 2 times, most recently from 76fe208 to ef15eca Compare September 2, 2025 22:43
@kcrocombe
Copy link
Author

/hold
Investigating the additional commits - suspecting rebase snafu

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 3, 2025
@kcrocombe kcrocombe closed this Sep 3, 2025
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kcrocombe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Change to remote API; merits scrutiny machine release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants