Revert "Remove bin/podman.cross Make target"

[Luap99]

This reverts commit c45b27f.

This commit was just wrong, local-cross depends on this target as it calls a target like "bin/podman.cross.linux.amd64". Without this it is just broken as there is no matching target.

$ make bin/podman.cross.linux.amd64
make: *** No rule to make target 'bin/podman.cross.linux.amd64'. Stop.

Does this PR introduce a user-facing change?

None

[Luap99]

cc @ninja-quokka

[baude]

makes sense, what do we do with local-cross ?

[Luap99]

makes sense, what do we do with local-cross ?

CI I wise nothing, but I need that target locally to ensure we can cross compile all supported targets. useful if you mess around with linux/freebsd only files and you need to know they all compile.
Yes CI will catch cross compile issues but they use a different target, as the jobs are split to speed them up and do not use the catch-all local-cross target.

[baude]

LGTM

[ninja-quokka]

makes sense, what do we do with local-cross ?

CI I wise nothing, but I need that target locally to ensure we can cross compile all supported targets. useful if you mess around with linux/freebsd only files and you need to know they all compile. Yes CI will catch cross compile issues but they use a different target, as the jobs are split to speed them up and do not use the catch-all local-cross target.

Thanks for the clarification @Luap99, can you add another commit to this PR on top of the revert to improve the comment for this target?

[Luap99]

Updated the docs and added another commit to fix the missing SOURCES dep which made it not rebuild on changes.

[ninja-quokka]

Updated the docs and added another commit to fix the missing SOURCES dep which made it not rebuild on changes.

Perfect, LGTM, only in case you need to push again there is a tiny typo in your last commit message:

"Without this the corss cross binaries"

[ninja-quokka]

/LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, ninja-quokka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

FYI, I needed this target for testing 2c89069
I have to be able to test stuff locally to not break embargo's.