test/system: some small fixes #26947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
Honny1
reviewed
Sep 2, 2025
test/system/120-load.bats
Outdated
| # Bind-mount the archive to a container running httpd | ||
| run_podman run -d --name myweb -p "$HOST_PORT:80" \ | ||
| run_podman $safe_opts run -d --name myweb -p "$HOST_PORT:80" \ |
There was a problem hiding this comment.
Tests are failing because podman-remote doesn't support the --root flag.
There was a problem hiding this comment.
yeah right, but I don't like to skip the test one remote as the download path should be tested there as well.
I guess I have to use a second image
This is an unnecessary network connection that flakes from time to time. Spawn our own local server instead and use that. That also allows to check that the actual file content has been copied. Signed-off-by: Paul Holzinger <[email protected]>
The test pulled a new $IMAGE already because it runs the http server container. So this doesn't striclty ensure the load works correctly. Make sure to actually test the load of a different image, so we use $PODMAN_NONLOCAL_IMAGE_FQN for that like another load test already does. I noticed this as the image pull on the webserver start flaked in a openQA run. Using _prefetch should help to reduce the network pulls here as it caches the image locally once it is pulled for the first time. Signed-off-by: Paul Holzinger <[email protected]>
The distro-integration tag was added for fedora openQA to only run a subset of tests. However since it was added only a few new tests have been labelled like that and in general a normal contributor or even maintianer has no idea when to add this tag. We also have been seeing several regressions getting into fedora that these tests would have caught. As such I worked with Adam to enable all tests for fedora openQA so we actually have proper coverage. This has been working for a few weeks so I think we can dop these tags so upstream does not need to bother with them at all. https://pagure.io/fedora-qa/os-autoinst-distri-fedora/issue/373 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
force-pushed
the
system-test-fixes
branch
from
9cc4729 to
247a80d
Compare
Honny1
approved these changes
Sep 2, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits
Does this PR introduce a user-facing change?