Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 5.5.0-dev #25178

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Jan 31, 2025

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2025
@lsm5
Copy link
Member Author

lsm5 commented Jan 31, 2025

set skip-ci for now.

@Luap99 @baude remind me, do we need anything fixed on the machine images side for this to work?

@Luap99
Copy link
Member

Luap99 commented Jan 31, 2025

yes we need new machine images as usual containers/podman-machine-os#73
containers/podman-machine-wsl-os#12

@baude
Copy link
Member

baude commented Feb 3, 2025

@l0rd can you spin up a 5.5 image so we can bump main to 5.4-dev?

@l0rd
Copy link
Member

l0rd commented Feb 3, 2025

@baude it should be fine, the 5.5 tag has been created a couple of days ago:

image

@mheon
Copy link
Member

mheon commented Feb 3, 2025

@lsm5 Want to drop the LGTM?

@mheon
Copy link
Member

mheon commented Feb 3, 2025

Sorry, WIP

@Luap99
Copy link
Member

Luap99 commented Feb 4, 2025

This needs a full proper cirrus CI run though, so it should not use skip-ci here

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 changed the title [skip-ci] Bump version to 5.5.0-dev Bump version to 5.5.0-dev Feb 4, 2025
@mheon
Copy link
Member

mheon commented Feb 4, 2025

Hell of a lot of flakes, but they do all seem to be flakes.

We probably need to look at the checkpoint/restore flakes soon though, they are getting bad.

@lsm5 lsm5 marked this pull request as ready for review February 5, 2025 10:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2025
@lsm5
Copy link
Member Author

lsm5 commented Feb 5, 2025

removed draft status. PTAL.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Feb 5, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 9cac035 into containers:main Feb 5, 2025
88 of 89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants