Add type and annotations to artifact add #25170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
approved
github-actions
bot
added
the
kind/api-change
baude
force-pushed
the
artifactoptions
branch
3 times, most recently
from
822d6be to
c744dd7
Compare
Luap99
reviewed
Jan 31, 2025
|
|
||
| // ParseAnnotations takes a string slice of options, expected to be "key=val" and returns | ||
| // a string map where the map index is the key and points to the value | ||
| func ParseAnnotations(options []string) (map[string]string, error) { |
There was a problem hiding this comment.
Not blocking BUT we really need to start to do better package names, this util/utils package madness is inside.
Point in case you having to rename the import to utils2 in the api code. That is just super ugly to read.
There was a problem hiding this comment.
i think that is a lovely tech debt item we could do ...
baude
force-pushed
the
artifactoptions
branch
from
c744dd7 to
027794c
Compare
Honny1
reviewed
Jan 31, 2025
Luap99
reviewed
Jan 31, 2025
baude
force-pushed
the
artifactoptions
branch
from
027794c to
cd26ab0
Compare
podman artifact add now supports two new command line switches. --type string that describes the type of artifact --annotation string slice in the form of key=val These new options allow users to "tag" information in on their artifacts for any number of purposes down the line RUN-2446 Signed-off-by: Brent Baude <[email protected]>
baude
force-pushed
the
artifactoptions
branch
from
cd26ab0 to
bd061aa
Compare
|
related to and blocks #25179 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, Honny1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman artifact add now supports two new command line switches.
--type string that describes the type of artifact
--annotation string slice in the form of key=val
These new options allow users to "tag" information in on their artifacts for any number of purposes down the line
RUN-2446
Does this PR introduce a user-facing change?