Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: use reflink to speed up checkpoint/restore #25050

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

cmd/podman: setuid to root if running with euid root

e095781
Select commit
Loading
Failed to load commit list.
Open

DRAFT: use reflink to speed up checkpoint/restore #25050

cmd/podman: setuid to root if running with euid root
e095781
Select commit
Loading
Failed to load commit list.
Cirrus CI / Build for MacOS amd64+arm64 failed Jan 28, 2025 in 47s

Task Summary

Instruction lint failed in 00:34

Details

✅ 00:08 clone
✅ 00:01 prep
❌ 00:34 lint

make golangci-lint
Makefile:152: invalid `override' directive
VERSION=1.63.4 ./hack/install_golangci.sh
Installing golangci-lint v1.63.4 into ./bin/golangci-lint
golangci/golangci-lint info checking GitHub for tag 'v1.63.4'
golangci/golangci-lint info found version: 1.63.4 for v1.63.4/darwin/arm64
golangci/golangci-lint info installed ./bin/golangci-lint
hack/golangci-lint.sh run

Running golangci-lint for REMOTE
Build Tags REMOTE: remote,containers_image_openpgp
Skipped directories REMOTE: libpod/events,pkg/machine/qemu,pkg/machine/wsl,test
+ ./bin/golangci-lint run --timeout=10m --build-tags=remote,containers_image_openpgp --exclude-dirs=libpod/events,pkg/machine/qemu,pkg/machine/wsl,test
pkg/domain/infra/tunnel/images.go:22:2: "github.com/containers/podman/v5/pkg/errorhandling" imported and not used (typecheck)
	"github.com/containers/podman/v5/pkg/errorhandling"
	^
pkg/checkpoint/crutils/checkpoint_restore_utils.go:112:16: undefined: archive.Timer (typecheck)
	defer archive.Timer("rootfsdiff", int(fi.Size()))()
	              ^
pkg/checkpoint/crutils/checkpoint_restore_utils.go:164:21: undefined: archive.TarWithOptionsTo (typecheck)
		if err := archive.TarWithOptionsTo(mountPoint, tw, &archive.TarOptions{
		                  ^
pkg/checkpoint/crutils/checkpoint_restore_utils.go:167:4: unknown field AlignBlockFile in struct literal of type archive.TarOptions (typecheck)
			AlignBlockFile:   rootfsDiffFile,
			^
pkg/bindings/images/build.go:722:8: undefined: tar (typecheck)
	tw := tar.NewWriter(gw)
	      ^
pkg/bindings/images/build.go:797:18: undefined: tar (typecheck)
					hdr, err := tar.FileInfoHeader(info, "")
					            ^
pkg/bindings/images/build.go:804:22: undefined: tar (typecheck)
						hdr.Typeflag = tar.TypeLink
						               ^
pkg/bindings/images/build.go:832:19: undefined: tar (typecheck)
					hdr, lerr := tar.FileInfoHeader(info, name)
					             ^
pkg/bindings/images/build.go:850:19: undefined: tar (typecheck)
					hdr, lerr := tar.FileInfoHeader(info, link)
					             ^
pkg/machine/ocipull/ocidir.go:101:7: undefined: tar (typecheck)
	t := tar.NewReader(uncompressedReader)
	     ^
make: *** [golangci-lint] Error 1

Exit status: 2