Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contrib: use a distinct --pull-option= for each flag #23257

Merged
merged 1 commit into from
Jul 12, 2024
Merged

contrib: use a distinct --pull-option= for each flag #23257

merged 1 commit into from
Jul 12, 2024

Conversation

giuseppe
Copy link
Member

Does this PR introduce a user-facing change?

None

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/containers-podman-23257 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-podman-23257 chroots=['centos-stream-9-x86_64', 'centos-stream-10-aarch64', 'centos-stream-10-x86_64', 'centos-stream-9-aarch64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@giuseppe giuseppe force-pushed the fix-pass-pull-option branch from 6b0f2c4 to a6b890f Compare July 12, 2024 10:05
rhatdan
rhatdan reviewed Jul 12, 2024
View reviewed changes
contrib/cirrus/setup_environment.sh
# actually works. Just MAKE SURE THERE ARE NO SPACES IN THE {...}!
export STORAGE_OPTIONS_OVERLAY='overlay.use_composefs=true --pull-option {enable_partial_images="true",use_hard_links="false",ostree_repos="",convert_images="true"}'
# actually works.
export STORAGE_OPTIONS_OVERLAY='overlay.use_composefs=true --pull-option=enable_partial_images=true --pull-option=convert_images=true'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does containers/storage now understand --pull-option in environment variable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, that is consumed directly by common_test.go that converts it to the CLI options

@Luap99
Copy link
Member

Luap99 commented Jul 12, 2024 

level=warning msg="Execution of `modprobe overlay` ended with error: exit status 1"

From rootless system tests

@giuseppe
Copy link
Member Author

caused by containers/storage@48e010f

@Honny1 can you please lower that to a debug message?

@giuseppe
Copy link
Member Author

caused by containers/storage@48e010f

@Honny1 can you please lower that to a debug message?

opened a PR containers/storage#2019

@giuseppe giuseppe force-pushed the fix-pass-pull-option branch from a6b890f to b1e535b Compare July 12, 2024 10:51
@giuseppe
Copy link
Member Author

dropped the c/storage bump, I'll deal with that later

Luap99
Luap99 reviewed Jul 12, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is there way for us to throw an error when invalid options are passed to prevent these kind of errors?

@giuseppe
Copy link
Member Author

LGTM, is there way for us to throw an error when invalid options are passed to prevent these kind of errors?

currently not, opened an issue to not forget about it: containers/storage#2020

@rhatdan
Copy link
Member

rhatdan commented Jul 12, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2415b4f into containers:main Jul 12, 2024
89 checks passed
@giuseppe giuseppe mentioned this pull request Jul 12, 2024
Closed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 11, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

@rhatdan rhatdan rhatdan left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giuseppe @Luap99 @rhatdan