feat: test InstructLab in a container

[jeffmaury]

What does this PR do?

Fixes #2226

Allow to start InstructLab container and open a terminal

Screenshot / video of UI

What issues does this PR fix or reference?

#2226

How to test this PR?

1. Start Podman AI Lab
2. Select the Test InstructLab menu
3. Click the Start InstructLab container button
4. Click the Open InstructLab container button

[slemeur]

👍 Thanks @jeffmaury for this. It's looking great and the ability to open the terminal directly will be helpful.

Couple of suggestions:

• Can we separate the instructions from the box that allows to start the container?
• Once the container is started, could we have the button saying "Open Instruct Lab terminal" ?

[axel7083]

A bit weird to have the buttons on the top ?

[jeffmaury]

See @slemeur

[slemeur]

When the action is not started, the buttons are at the top.
Once the user clicked on the "Start" button, the triggered actions display bellow the action, which seems the natural reading order and avoid the page's primary actions to be moving in the screen.

[axel7083]

This is not really consistent with the other forms where the buttons are on the bottom right

[slemeur]

But that's not a form. There is only one action the user can do on this screen.

[axel7083]

We might want to create a task with a goto action, as when leaving the page we cannot go back, the pulling can take a lot of time.. so might be nice to be able to leave the page and go back to it.)

I am open to have it as a separate task, (let's add it to the epic #2224 ?

[slemeur]

@jeffmaury : to confirm, is the telemetry triggered when the user clicks on the "start" button?

[jeffmaury]

@jeffmaury : to confirm, is the telemetry triggered when the user clicks on the "start" button?

Fixed by 9e7822d

[gastoner]

On Windows:
Invisible text in light theme

+1 Axel, I would expect also the buttons on bottom right

The cancel button does not do anything, the page have a different template?
https://github.com/user-attachments/assets/7a40398b-fe6a-485d-921f-a697bff9f11f

[axel7083]

I was able to try it on Linux and I am getting permission issues

bash-4.4$ ilab config init
Traceback (most recent call last):
  File "/usr/local/bin/ilab", line 8, in <module>
    sys.exit(ilab())
             ^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/instructlab/clickext.py", line 319, in wrapper
    return f(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/click/decorators.py", line 33, in new_func
    return f(get_current_context(), *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/instructlab/config/init.py", line 100, in init
    fresh_install = ensure_storage_directories_exist()
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/instructlab/configuration.py", line 1122, in ensure_storage_directories_exist
    os.makedirs(dirpath, exist_ok=True)
  File "<frozen os>", line 225, in makedirs
PermissionError: [Errno 13] Permission denied: '/instructlab/.local/share/instructlab/chatlogs'
bash-4.4$

This is probably due to a missing label/configuration on the mounted folder(s).

[axel7083]

LGTM

[gastoner]

When I try to delete the container and the image after the start+open.
Then go back to try instructlab, the start button is starting container again

Screen.Recording.2025-01-14.111620.mp4

[gastoner]

Add some space between buttons?

[gastoner]

Going to Tune with instructlab will stop showing the in progress button:

Screen.Recording.2025-01-14.111243.mp4

[axel7083]

LGTM