Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor for constants #12

Merged
merged 2 commits into from
Sep 3, 2024
Merged

chore: refactor for constants #12

merged 2 commits into from
Sep 3, 2024

Conversation

tarilabs
Copy link
Member

No description provided.

isinyaaa
isinyaaa approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@isinyaaa isinyaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

omlmd/helpers.py Outdated Show resolved Hide resolved
@tarilabs tarilabs force-pushed the tarilabs-20240828-const branch 2 times, most recently from de32d62 to f71de00 Compare August 28, 2024 14:12
@tarilabs @isinyaaa
Update omlmd/helpers.py
30d9677 
Signed-off-by: Matteo Mortari <[email protected]>

Co-authored-by: Isabella Basso <[email protected]>
@tarilabs tarilabs force-pushed the tarilabs-20240828-const branch from f71de00 to 30d9677 Compare August 28, 2024 14:13
@tarilabs
Copy link
Member Author

tarilabs commented Sep 3, 2024

thanks again Isabella

@tarilabs tarilabs merged commit 410c173 into containers:main Sep 3, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isinyaaa isinyaaa isinyaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarilabs @isinyaaa