vsock/tsi: converts BSD sockaddr to Linux wire format to prevent invalid sa_family in guests #543
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD and Linux have different
sockaddr_inlayouts:Without converting to LINUX-style, the
sa_lenfield present in macOS(BSD-style) sockaddr is misinterpreted as part ofsa_familyby the guest kernel, causingaccept()to return an invalid address family.This crashes any guest program that inspects the peer address after
accept():crash log (
sa_family=0x210which is invalid length):This PR converts BSD sockaddr to Linux wire format to fix this issue