Replace KILLPRIV with KILLPRIV_V2 #532
Open
+417
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
We never really supported HANDLE_KILLPRIV, so let's be honest about it and stop announcing it. Signed-off-by: Sergio Lopez <[email protected]>
We're going to need this library in the next commit libcap-ng-dev. Signed-off-by: Sergio Lopez <[email protected]>
KILLPRIV_V2 is a FUSE flag that indicates that the filesystem is
responsible for clearing security.capability xattr and clearing setuid
and setgid bits, following these rules:
- clear "security.capability" on write, truncate and chown unconditionally
- clear suid/sgid if following is true. Note, sgid is cleared only if
group executable bit is set.
o setattr has FATTR_SIZE and FATTR_KILL_SUIDGID set.
o setattr has FATTR_UID or FATTR_GID
o open has O_TRUNC and FUSE_OPEN_KILL_SUIDGID
o create has O_TRUNC and FUSE_OPEN_KILL_SUIDGID flag set.
Signed-off-by: Sergio Lopez <[email protected]>
Those structs were mostly redundant, converge on InodeHandle. This also allows us to simplify and unify many code paths. Signed-off-by: Sergio Lopez <[email protected]>
Reuse the previously obtained libc::stat with get_xattr_* to avoid an additional stat syscall. Signed-off-by: Sergio Lopez <[email protected]>
Enable set_xattr_stat to receive a bindings::stat struct so we it can be provided in the cases where we've already obtained it, saving an additional stat syscall. Signed-off-by: Sergio Lopez <[email protected]>
slp
force-pushed
the
virtiofs-killpriv-v2
branch
from
33af184 to
1c23c77
Compare
Collaborator
Author
|
Tested with pjdfstest on both Linux and macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we were announcing it, we never really supported KILLPRIV, so this was breaking some fs tests. This PR stops announcing KILLPRIV support, and implements support for KILLPRIV_V2.