manifest: ListUpdate add imgspecv1.Platform field
#2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtrmac @vrothberg @giuseppe PTAL Just a small PR to include |
flouthoc
force-pushed
the
listupdate-add-platform
branch
from
e39f3b3
to
dfb68e8
Compare
mtrmac
reviewed
Jul 7, 2023
flouthoc
force-pushed
the
listupdate-add-platform
branch
3 times, most recently
from
7494bfa
to
98aaf70
Compare
mtrmac
reviewed
Jul 7, 2023
flouthoc
force-pushed
the
listupdate-add-platform
branch
from
98aaf70
to
e7c50e2
Compare
mtrmac
approved these changes
Jul 7, 2023
| @@ -57,6 +57,7 @@ func (index *OCI1IndexPublic) Instance(instanceDigest digest.Digest) (ListUpdate | |||
| Digest: manifest.Digest, | |||
| Size: manifest.Size, | |||
| MediaType: manifest.MediaType, | |||
| Platform: manifest.Platform, | |||
There was a problem hiding this comment.
It would be a bit safer to make a clone instead of providing a pointer to our data, but, meh, we can deal with that if it breaks I guess.
`c/image` uses `Instance(` API to get the required details of an instance while performing replication `Platform` of instance is needed hence `ListUpdate` must include platform. Needed by: containers#1987 Signed-off-by: Aditya R <[email protected]>
mtrmac
force-pushed
the
listupdate-add-platform
branch
from
e7c50e2
to
a243961
Compare
This was referenced Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c/imageusesInstance(API to get the required details of an instance while performing replication,Platformof instance is needed so it can use it again while adding an instance hence addingPlatformtoListUpdateNeeded by: #1987
See prior comment here: #1875 (comment)