-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: ListUpdate
add imgspecv1.Platform
field
#2029
Conversation
@mtrmac @vrothberg @giuseppe PTAL Just a small PR to include |
e39f3b3
to
dfb68e8
Compare
7494bfa
to
98aaf70
Compare
98aaf70
to
e7c50e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
@@ -57,6 +57,7 @@ func (index *OCI1IndexPublic) Instance(instanceDigest digest.Digest) (ListUpdate | |||
Digest: manifest.Digest, | |||
Size: manifest.Size, | |||
MediaType: manifest.MediaType, | |||
Platform: manifest.Platform, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a bit safer to make a clone instead of providing a pointer to our data, but, meh, we can deal with that if it breaks I guess.
`c/image` uses `Instance(` API to get the required details of an instance while performing replication `Platform` of instance is needed hence `ListUpdate` must include platform. Needed by: containers#1987 Signed-off-by: Aditya R <[email protected]>
e7c50e2
to
a243961
Compare
c/image
usesInstance(
API to get the required details of an instance while performing replication,Platform
of instance is needed so it can use it again while adding an instance hence addingPlatform
toListUpdate
Needed by: #1987
See prior comment here: #1875 (comment)