Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: use authPath struct consistently #1765

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

cgwalters
Copy link
Contributor

@cgwalters cgwalters commented Dec 15, 2022

config: use authPath struct consistently

Instead of packing and unpacking it into two variables in
various places. Prep for adding a third member of this struct
as part of #1746

Signed-off-by: Colin Walters [email protected]


config: Make parsing function a method on authFile

Just a general cleanup.


Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM, just a few possible cleanups to ease future maintenance.

pkg/docker/config/config.go Outdated Show resolved Hide resolved
pkg/docker/config/config.go Outdated Show resolved Hide resolved
pkg/docker/config/config.go Outdated Show resolved Hide resolved
pkg/docker/config/config_test.go Outdated Show resolved Hide resolved
pkg/docker/config/config.go Show resolved Hide resolved
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
once @mtrmac comments are addressed.

Instead of packing and unpacking it into two variables in
various places.  Prep for adding a third member of this struct
as part of containers#1746

Signed-off-by: Colin Walters <[email protected]>
Just a general cleanup.

Signed-off-by: Colin Walters <[email protected]>
@cgwalters
Copy link
Contributor Author

Thanks, addressed those comments, and also added a further cleanup commit.

@rhatdan rhatdan merged commit debf9d8 into containers:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants