-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: use authPath
struct consistently
#1765
Conversation
79ea7c2
to
12a3809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
LGTM, just a few possible cleanups to ease future maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
once @mtrmac comments are addressed.
Instead of packing and unpacking it into two variables in various places. Prep for adding a third member of this struct as part of containers#1746 Signed-off-by: Colin Walters <[email protected]>
12a3809
to
a0f60f6
Compare
Just a general cleanup. Signed-off-by: Colin Walters <[email protected]>
a0f60f6
to
7920ffb
Compare
Thanks, addressed those comments, and also added a further cleanup commit. |
config: use
authPath
struct consistentlyInstead of packing and unpacking it into two variables in
various places. Prep for adding a third member of this struct
as part of #1746
Signed-off-by: Colin Walters [email protected]
config: Make parsing function a method on authFile
Just a general cleanup.