-
Notifications
You must be signed in to change notification settings - Fork 383
linux: fix definition of CLONE_NEWTIME on Centos 9 #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: fix definition of CLONE_NEWTIME on Centos 9 #1719
Conversation
Include <linux/sched.h> header to provide the proper definition of CLONE_NEWTIME. Closes: containers#1718 Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Signed-off-by: Giuseppe Scrivano <[email protected]>
Reviewer's Guide by SourceryThis pull request fixes the definition of No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @giuseppe - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're adding a header and also redefining some flags; can you confirm that the header inclusion actually fixes the problem and the redefinitions aren't also needed?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
flouthoc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wow nice summary by Sourcery
Include <linux/sched.h> header to provide the proper definition of CLONE_NEWTIME.
Closes: #1718
Summary by Sourcery
Fix the definition of CLONE_NEWTIME and CLONE_NEWCGROUP constants for compatibility on Centos 9
Bug Fixes:
Enhancements: