Skip to content

Conversation

@flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Apr 3, 2025

krun returns incomplete error without this patch which is difficult to debug

Error: OCI runtime error: /home/crun/krun: failed to open library `libkrun.so.1` and `libkrun-sev.so.1` for krun_config

after patch

Error: /home/ar/work/crun/krun: failed to open library `libkrun.so.1` and `libkrun-sev.so.1` for krun_config: libkrun-sev.so.1: cannot open shared object file: No such file or directory: OCI runtime attempted to invoke a command that was not found

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 3, 2025

@giuseppe WDYT ? I found this issue while playing around, I had to manually add printf to debug.

@flouthoc flouthoc requested a review from giuseppe April 3, 2025 03:46
krun returns incomplete error without this patch which is difficult to debug
```console
Error: OCI runtime error: /home/crun/krun: failed to open library `libkrun.so.1` and `libkrun-sev.so.1` for krun_config
```

after patch
```console
Error: /home/ar/work/crun/krun: failed to open library `libkrun.so.1` and `libkrun-sev.so.1` for krun_config: libkrun-sev.so.1: cannot open shared object file: No such file or directory: OCI runtime attempted to invoke a command that was not found
```

Signed-off-by: flouthoc <[email protected]>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Member

giuseppe commented Apr 3, 2025

do you want to merge this patch or need to work more on it?

@flouthoc
Copy link
Collaborator Author

flouthoc commented Apr 3, 2025

We can merge this.

@giuseppe giuseppe merged commit 9c972c3 into containers:main Apr 3, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants