feat: add get cursor position #269
Open
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Grantham <[email protected]>
djc
reviewed
Aug 22, 2025
examples/cursor_position.rs
Outdated
| @@ -0,0 +1,50 @@ | |||
| extern crate console; | |||
There was a problem hiding this comment.
I don't think think every tiny feature merits an example that then has to be maintained forever -- I think how to use this feature is pretty clear and the effort is better spent on good API docs.
src/ansi.rs
Outdated
| @@ -189,7 +189,7 @@ fn find_ansi_code_exclusive(it: &mut Peekable<CharIndices>) -> Option<(usize, us | |||
|
|
|||
| /// Helper function to strip ansi codes. | |||
| #[cfg(feature = "alloc")] | |||
| pub fn strip_ansi_codes(s: &str) -> Cow<str> { | |||
| pub fn strip_ansi_codes(s: &str) -> Cow<'_, str> { | |||
There was a problem hiding this comment.
Since this is independent of your other changes, please isolate it in a separate commit.
src/unix_term.rs
Outdated
| io::stdout().flush()?; | ||
|
|
||
| // Read the response from the terminal | ||
| let key = read_single_key(false)?; |
There was a problem hiding this comment.
Nit: please inline the key binding.
Signed-off-by: Dave Grantham <[email protected]>
|
reverted back to 0.16.0 as well. |
djc
reviewed
Aug 31, 2025
| @@ -258,6 +258,44 @@ fn read_single_key_impl(fd: RawFd) -> Result<Key, io::Error> { | |||
| 'H' => Ok(Key::Home), | |||
| 'F' => Ok(Key::End), | |||
| 'Z' => Ok(Key::BackTab), | |||
| '0'..='9' => { | |||
There was a problem hiding this comment.
Does it make sense to keep this inside read_single_key_impl() when it effectively is only expected inside a call to read_single_key()?
(Part of this is is the very deeply nested indentation level making this code harder to follow.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to get the current cursor position using the ansi cursor
position query sequence. Sometimes it is useful to know where you are in the
terminal when your program first starts up, or when you are doing some complex
terminal manipulation.
Signed-off-by: Dave Grantham [email protected]