fix(tester): re-apply MacOS CI fix (commit 6fde964) #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasdewally
force-pushed
the
nik/reapply-blocking-rule-trace-commit
branch
from
7e14ca6 to
d077441
Compare
niklasdewally
changed the title
niklasdewally
force-pushed
the
nik/reapply-blocking-rule-trace-commit
branch
from
d077441 to
5f986f9
Compare
ozgurakgun
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapply 6fde964 (fix(tester): make human rule trace writer blocking, 2025-01-08)
PR #569 accidentally reverted this change, causing ACCEPT=true failures
on my Mac and some CI failures.
This commit also adds the previous fix to the new JSON logging layer.