Add powers and convert to Minion #589
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement powers `x**y`. * Add the `UnsafePow`, `SafePow`, and `FlatPow` expressions * JSON Parsing of `x**y` into `UnsafePow`. * Defindness semantics / bubble rules. * Add partial / total evaluation. * Flatten `SafePow` expressions. * Add Minion introduction rule for `FlatPow`. * Add solver adaptor support. UNDEFINEDNESS SEMANTICS `x**y=z` is defined when: ``` (x!=0 \/ y!=0) /\ y>=0 ``` [Savile Row Manual] This commit adds a `UnsafePow` and `SafePow` expression, representing the power operation before and after it has been made safe. Similarly to division, safety is achieved by converting `UnsafePow` to `SafePow`, and bubbling up the definedness condition `(x!=0 \/ y!=0) /\ y>=0)`.
|
Ready to review; just need to double check and document Minion's |
Add powers and convert to Minion Implement powers `x**y`. * Add the `UnsafePow`, `SafePow`, and `FlatPowEq` expressions * JSON Parsing of `x**y` into `UnsafePow`. * Defindness semantics / bubble rules. * Add partial / total evaluation. * Flatten `SafePow` expressions. * Add Minion introduction rule for `FlatPowEq`. * Add solver adaptor support. UNDEFINEDNESS SEMANTICS `x**y=z` is defined when: ``` (x!=0 \/ y!=0) /\ y>=0 ``` [Savile Row Manual] This commit adds a `UnsafePow` and `SafePow` expression, representing the power operation before and after it has been made safe. Similarly to division, safety is achieved by converting `UnsafePow` to `SafePow`, and bubbling up the definedness condition `(x!=0 \/ y!=0) /\ y>=0)`.
ozgurakgun
reviewed
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement powers
x**y.UnsafePow,SafePow, andFlatPowEqexpressionsx**yintoUnsafePow.SafePowexpressions.FlatPow.UNDEFINEDNESS SEMANTICS
x**y=zis defined when:[Savile Row Manual]
This commit adds a
UnsafePowandSafePowexpression, representingthe power operation before and after it has been made safe.
Similarly to division, safety is achieved by converting
UnsafePowtoSafePowand bubbling up the definedness condition(x!=0 \/ y!=0) /\ y>=0).