Add support for JSON/camelcase conversion #2705
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new configuration boolean configuration "json.field.names" (defaults to false) which controls whether to convert to JSON/camelcase from protobuf field names (which are underscore-separated by convention) – in
toConnectData
.Conversely, going from the internal data representation, if this option is enabled, we convert from JSON/camelcase back to underscore-separated – in
fromConnectData
.Note that this option is compatible with the Protobuf Style Guide in the sense that for some languages (e.g. Java), the underscore field naming is translated to camelcase-based methods.