CPBR-1910 add maven configs for nightly pipelines #180
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Analysis Details0 Issues
Coverage and Duplications
Project ID: ksql-images |
| . vault-sem-get-secret maven-settings-cp-dockerfile | ||
| else | ||
| echo "This job is not a isHotfixJob or isRcJob (What we know how to handle) - and we don't know how to handle it" | ||
| export MAVEN_PACKAGES_URL="https://s3.us-west-2.amazonaws.com/dev-confluent-packages-maven-654654529379-us-west-2/maven" # This is default set for PR builds not having a packaging build number |
There was a problem hiding this comment.
Question: When we do maven-login build locally, will it use the same URL? Or do we need to make changes in the settings.xml. My aim is local build should same as PR builder and semaphore nightly builds
There was a problem hiding this comment.
settings.xml will be different locally
The settings.xml for semaphore pipelines building docker images is present on vault under v1/ci/kv/semaphore2/maven-settings-cp-dockerfile
There was a problem hiding this comment.
Locally maven jars from nightly S3 bucket are not available today as nightly maven jars are not configured to show up on https://nightly-packages.confluent.io/
@hk10111 can you look into cloudfront entry required to make it available.
@kagarwal06 we can have a separate secret for local development which will replace s3.us-west-2.amazonaws.com/dev-confluent-packages-maven-654654529379-us-west-2/maven/ with nightly-packages.confluent.io/maven/
There was a problem hiding this comment.
@kagarwal06 maven jars are now available on https://nightly-packages.confluent.io/
This will make local development similar to PR builds
During CP docker image builds, nightly build have different configuration than RC builds due to which some issues do not get caught in nightly pipelines
One such configuration is the maven configs
This PR makes the maven configs similar for both nightly and rc builds