Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify: replace key&value deserializer to CompatAvroDeserializer #576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
/*
* Copyright 2018 Confluent Inc.
*
* Licensed under the Confluent Community License (the "License"); you may not use
* this file except in compliance with the License. You may obtain a copy of the
* License at
*
* http://www.confluent.io/confluent-community-license
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/

package io.confluent.kafkarest.serializers;

import io.confluent.kafka.serializers.KafkaAvroDeserializer;
import java.nio.ByteBuffer;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class CompatAvroDeserializer extends KafkaAvroDeserializer {
private static final Logger log = LoggerFactory.getLogger(CompatAvroDeserializer.class);

@Override
public Object deserialize(String s, byte[] bytes) {
try {
ByteBuffer buffer = ByteBuffer.wrap(bytes);
buffer.get();
return super.deserialize(s, bytes);
} catch (Exception e) {
log.error("Failed to deserialize {}" + s, e.toString());
return e.toString();
}

}

}
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,10 @@ public String createConsumer(String group, ConsumerInstanceConfig instanceConfig

switch (instanceConfig.getFormat()) {
case AVRO:
props.put("key.deserializer", "io.confluent.kafka.serializers.KafkaAvroDeserializer");
props.put("value.deserializer", "io.confluent.kafka.serializers.KafkaAvroDeserializer");
props.put("key.deserializer",
"io.confluent.kafkarest.serializers.CompatAvroDeserializer");
props.put("value.deserializer",
"io.confluent.kafkarest.serializers.CompatAvroDeserializer");
break;
case JSON:
case BINARY:
Expand Down