Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tgrade-ap-voting migrate multisig #513

Merged
merged 5 commits into from
Jul 19, 2022
Merged

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Jul 18, 2022

Add support for setting the multisig code id and waiting period during contract migration.

Both fields are currently not being set during tgrade bootstrap (See confio/tgrade#426). So, contract migration must include this in order for the ap-voting contract to be usable.

@maurolacy maurolacy requested review from hashedone, ueco-jb and uint July 18, 2022 05:17
@maurolacy maurolacy self-assigned this Jul 18, 2022
@maurolacy maurolacy added breaking breaking_api Changes msg.rs file labels Jul 18, 2022
@maurolacy maurolacy mentioned this pull request Jul 18, 2022
Co-authored-by: Jakub Bogucki <[email protected]>
Copy link

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maurolacy maurolacy merged commit 1bece1c into main Jul 19, 2022
@maurolacy maurolacy deleted the ap-voting-migrate-multisig-id branch July 19, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_api Changes msg.rs file breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants