Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: run e2e tests for libvirt with CRI-O #2068

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CI: run e2e tests for libvirt with CRI-O #2068

wants to merge 7 commits into from

Commits on Oct 8, 2024

  1. versions: bump version of kcli 

    In order to use kcli to create a k8s cluster with configured with
cri-o, it will be needed to use a version newer than 07/02/2024 which
containers the karmab/kcli@77cf2cb
fix. So picking the latest version available at the time of this commit.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    398d959 View commit details
    Browse the repository at this point in the history

  2. libvirt/kcli_cluster.sh: add support to CRI-O 

    By exporting the CONTAINER_RUNTIME=crio variable, kcli will create
a k8s cluster configured CRI-O:

$ export CONTAINER_RUNTIME=crio
$ ./src/cloud-api-adaptor/libvirt/kcli_cluster.sh create

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c179d8c View commit details
    Browse the repository at this point in the history

  3. test/e2e: new container_runtime property for libvirt 

    Commit a0247ae introduced a new parameter (CONTAINER_RUNTIME) for docker
provider, allowing users to specify the container runtime used. Some tests will
take decisions based on that property, for example, whether nydus snapshotter
messages should be inspected or not. Likewise, this added the handler for that
property for libvirt, so allowing to test with cri-o too.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    dc89125 View commit details
    Browse the repository at this point in the history

  4. workflows/libvirt: add e2e job to test with CRI-O 

    Added a new container_runtime matrix column to generate
one job for each runtime: containerd and crio.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8a12b1a View commit details
    Browse the repository at this point in the history

  5. workflows/libvirt: allow the e2e crio job to fail 

    Let's keep it running for a while on CI, once it's stable we can
remove the continue-on-error.

Fixes confidential-containers#1981
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    0931173 View commit details
    Browse the repository at this point in the history

  6. test/e2e: adapt DoTestRestrictivePolicyBlocksExec for CRI-O 

    The DoTestRestrictivePolicyBlocksExec test for CRI-O will have the
"error executing command in container" error message instead of
"failed to exec in container". So adjusted the expected strings on
the error message to consider the output of CRI-O too.

Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1687ba8 View commit details
    Browse the repository at this point in the history

  7. test/e2e: skip libvirt tests for CRI-O 

    These test are already skipped on CI, also disabled them when running
locally because they fail.

Related-to: confidential-containers#2100
Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
    @wainersm
    wainersm committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    711ee01 View commit details
    Browse the repository at this point in the history