Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce bulkhead anf circuitbreaker config on workflow task level #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shaileshpadave
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • [] Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Circuit Breaker and Bulkhead Support for WorkflowTask

Changes

  • Added CircuitBreakerConfig class with configuration for failure detection and recovery
  • Added BulkheadConfig class for concurrent execution control
  • Extended WorkflowTask with circuit breaker and bulkhead configurations
  • Added comprehensive test coverage for new configurations

Details

Circuit Breaker Configuration

  • failureRateThreshold: Percentage of failures to trigger circuit breaker
  • slidingWindowSize: Call window for failure rate calculation
  • minimumNumberOfCalls: Minimum calls before activation
  • waitDurationInOpenState: Recovery wait period
  • permittedNumberOfCallsInHalfOpenState: Test calls in recovery

Bulkhead Configuration

  • maxConcurrentCalls: Concurrent execution limit
  • maxWaitDuration: Maximum wait time for execution permission

Testing

Added test coverage for:

  • Circuit breaker configuration lifecycle
  • Bulkhead configuration lifecycle
  • Individual property setters/getters
  • Null safety checks

Describe the new behavior from this PR, and why it's needed
Issue #

Alternatives considered

Describe alternative implementation you have considered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant