Fix task def name npe #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmigueprieto
reviewed
Jan 9, 2025
| @@ -533,6 +533,9 @@ public TaskDef getTaskDefinition() { | |||
| * @param taskDefinition Task definition | |||
| */ | |||
| public void setTaskDefinition(TaskDef taskDefinition) { | |||
| if (taskDefinition != null && taskDefinition.getName() == null) { | |||
| taskDefinition.setName(this.name); | |||
There was a problem hiding this comment.
I would not expect a setX(X arg) to mutate the passed parameter. It’s not ideal to introduce side effects to a passed parameter.
Either avoid the side effect, document it clearly or create a copy.
There was a problem hiding this comment.
@shaileshpadave can you check where is this being called from and the caller should fix this.
jmigueprieto
requested changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
About the taskDef npe exception for http tasks!
When task definition is not provided and we are trying to use inputSchema in task, then during deserialisation, name will be set to null. We never checked for taskDef name before so never faced issue.
Fix:
Check if taskdef.getName() is null then set taskName.
Describe the new behavior from this PR, and why it's needed
Issue #
Alternatives considered
Describe alternative implementation you have considered