Reduce FORK/JOIN latency #352
Merged
+113
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmigueprieto
force-pushed
the
fix/join-latency-issues
branch
from
8c75eda to
bf90790
Compare
jmigueprieto
commented
Jan 6, 2025
| int index = taskModel.getPollCount() > 0 ? taskModel.getPollCount() - 1 : 0; | ||
| if (index == 0) { | ||
| public Optional<Long> getEvaluationOffset(TaskModel taskModel, long maxOffset) { | ||
| int pollCount = taskModel.getPollCount(); |
There was a problem hiding this comment.
To reduce the delay of the JOIN task when all forked tasks complete it will not be postponed until pollCount is above a given configurable threshold.
Once pollCount is greater than that threshold, the delay will increase until reaching maxOffset.
v1r3n
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Currently, a JOIN execution is delayed exponentially up to a maximum of
30sin the default configuration. This may cause a JOIN to complete with a significant delay compared to the actual completion of all forked tasks.These changes introduce a configurable postpone calculation (with a less aggressive increase) and a configurable Queue Pop Timeout. By tweaking those values we can reduce the JOIN latency at the start and the end.
SEE also: orkes-io/orkes-queues#19