Added lease extension to java sdk and fixed tests #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystxn
force-pushed
the
fix/add-lease-extension
branch
5 times, most recently
from
4e38713 to
21b81f7
Compare
ystxn
force-pushed
the
fix/add-lease-extension
branch
from
21b81f7 to
395c672
Compare
| @@ -36,6 +35,7 @@ java { | |||
|
|
|||
| test { | |||
| useJUnitPlatform() | |||
| maxParallelForks = 1 | |||
There was a problem hiding this comment.
@ystxn why is this required?
This might significantly slow down tests, since there will be no parallel test execution.
There was a problem hiding this comment.
I see now that tests weren't running because they were using JUnit4 annotations.
jmigueprieto
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Issue #306