Add total timeout backend #318
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +47,8 @@ public enum RetryLogic { | |||
|
|
|||
There was a problem hiding this comment.
@shaileshpadave anything that's under conductor-clients/java/conductor-java-sdk/ is part of the Java Client v4 project.
Let's keep the conductor core changes and client changes in separate PRs
shaileshpadave
force-pushed
the
addTotalTimeout_backend
branch
from
e922fff to
e0174b6
Compare
shaileshpadave
force-pushed
the
addTotalTimeout_backend
branch
from
e0174b6 to
7f47427
Compare
jmigueprieto
reviewed
Dec 2, 2024
| @@ -498,6 +498,7 @@ public void testTaskTimeout() { | |||
| taskType.setName("test"); | |||
| taskType.setTimeoutPolicy(TimeoutPolicy.RETRY); | |||
| taskType.setTimeoutSeconds(1); | |||
| taskType.setTotalTimeoutSeconds(1_000); | |||
There was a problem hiding this comment.
- Why a
1000second total timeout for this test? - Is this test covering the changes made to
checkTaskTimeout?
jmigueprieto
reviewed
Dec 2, 2024
| } | ||
|
|
||
| String reason = | ||
| String.format( | ||
| "Task timed out after %d seconds. Timeout configured as %d seconds. " | ||
| + "Total Task Timeout configured as %d seconds. " |
There was a problem hiding this comment.
This reason may be confusing.
It's not immediately clear which timeout kicked in since it's mentioning both (timeout and total timeout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Code changes to check if total task timeout has reached or not, if yes then workflow should be terminated.